Skip to content

[FormRecognizer] Preview 1: detect content type when not provided #11357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kinelski merged 4 commits into from
Apr 17, 2020
Merged

[FormRecognizer] Preview 1: detect content type when not provided #11357

kinelski merged 4 commits into from
Apr 17, 2020

Conversation

@kinelski
Copy link
Contributor

@kinelski kinelski commented Apr 16, 2020

Summary

The new TryGetContentType extension method searches through the first set of bytes of a given stream and compares it to well-known file signatures in order to figure out its content type. This method call can be avoided by the developer when the ContentType property in RecognizeOptions has its value defined and not null.

Changes

  • Creation of StreamExtensions file to include the new TryGetContentType method.
  • Addition of the ContentType property to RecognizeOptions.
  • FormRecognizerClient methods updated to make use of the content type detection.
  • contoso-allinone.png and Invoice_1.tiff files added to the assets folder to help testing the type detection. These files are expected to be used in future tests as well.
  • TestEnvironment class updated to support new files.
  • StreamExtensionsTests class created to test the content type detection.

Fixes #10329
Fixes #11313

@kinelski kinelski added Cognitive Services Client This issue is related to a non-management package FormRecognizer labels Apr 16, 2020
@kinelski kinelski added this to the [2020] May milestone Apr 16, 2020
@kinelski kinelski requested a review from AlexGhiondea as a code owner April 16, 2020 00:39
@kinelski kinelski self-assigned this Apr 16, 2020
annelo-msft
annelo-msft approved these changes Apr 17, 2020
View reviewed changes
Copy link
Member

@annelo-msft annelo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kinelski kinelski merged commit 5984c9a into Azure:master Apr 17, 2020
@kinelski kinelski deleted the fr-detection branch April 17, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maririos maririos maririos left review comments

@annelo-msft annelo-msft annelo-msft approved these changes

@AlexGhiondea AlexGhiondea Awaiting requested review from AlexGhiondea

@mssfang mssfang Awaiting requested review from mssfang

+2 more reviewers

@AlexanderSher AlexanderSher AlexanderSher left review comments

@kristapratico kristapratico kristapratico left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@kinelski kinelski

Labels

Client This issue is related to a non-management package Cognitive - Form Recognizer Cognitive Services

Projects

None yet

Milestone

[2020] May

Development

Successfully merging this pull request may close these issues.

[FormRecognizer] Stop defaulting to PDF when content type detection is in place Auto-detect content-type in streams

5 participants

@kinelski @AlexanderSher @maririos @annelo-msft @kristapratico