Read the ClientRequestId off initial request#11304
Merged
pakrym merged 4 commits intoAzure:masterfrom Apr 14, 2020
Merged
Conversation
pakrym
commented
Apr 14, 2020
| } | ||
|
|
||
| [Test] | ||
| public async Task CustomClientRequestIdAvailableInPerCallPolicies() |
Contributor
Author
There was a problem hiding this comment.
Tests policy ordering.
Member
Good that we did not expose index-based API add new policies to client options :-) |
KrzysztofCwalina
approved these changes
Apr 14, 2020
Contributor
Author
|
This change is breaking, if perCallPolicies were setting I'm going to split this policy in two. |
tg-msft
approved these changes
Apr 14, 2020
| } | ||
|
|
||
| [Test] | ||
| public async Task CustomClientRequestIdSetInPerCallPolicyAppliedAsAHeader() |
Member
There was a problem hiding this comment.
Sorry for causing this problem - but thank you for making the scenario work.
Contributor
Author
There was a problem hiding this comment.
It's a good test I with I had before.
Contributor
Author
|
/azp run net - core - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to move the policy to be the first one in the pipeline so everyone can read the correct value of the Request.ClientRequestId. I couldn't come up with a scenario where it's breaking.
Fixes: #11198