CMK support for VMware migration and addition of few properties for VMware DR monitoring#10477
Merged
isra-fel merged 12 commits intoAzure:masterfrom Mar 12, 2020
Merged
CMK support for VMware migration and addition of few properties for VMware DR monitoring#10477isra-fel merged 12 commits intoAzure:masterfrom
isra-fel merged 12 commits intoAzure:masterfrom
Conversation
Contributor
|
Can one of the admins verify this patch? |
isra-fel
requested changes
Mar 11, 2020
Member
isra-fel
left a comment
isra-fel
left a comment
There was a problem hiding this comment.
Hi @anmolbhatia289 , could you
- Check in the
.txtfile generated when you rungenerate.ps1(details)- In case you have trouble running
generate.ps1, please update the autorest version in it fromlatestto2.0.4413
- In case you have trouble running
- Update release notes in csproj
- Write tests to cover new operations
Thanks
Contributor
Author
|
We are planning to add tests related to all migration item operations in a separate PR. Currently, none of the migration item operations have tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDK for net changes corresponding to the changes in PR : Azure/azure-rest-api-specs#8390