Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion sdk/core/Azure.Core/src/Shared/DiagnosticScope.cs
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,22 @@ public void AddAttribute<T>(string name, T value, Func<T, string> format)
}
}

public void AddLink(string id)
public void AddLink(string id, IDictionary<string, string>? attributes = null)
{
if (_activity != null)
{
var linkedActivity = new Activity("LinkedActivity");
linkedActivity.SetW3CFormat();
linkedActivity.SetParentId(id);

if (attributes != null)
{
foreach (var kvp in attributes)
{
linkedActivity.AddTag(kvp.Key, kvp.Value);
}
}

_activity.AddLink(linkedActivity);
}
}
Expand Down
36 changes: 36 additions & 0 deletions sdk/core/Azure.Core/tests/ClientDiagnosticsTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,42 @@ public void AddLinkCallsPassesLinksAsPartOfStartPayload()
Assert.AreEqual(0, testListener.Events.Count);
}

[Test]
public void AddLinkCreatesLinkedActivityWithTags()
{
using var testListener = new TestDiagnosticListener("Azure.Clients");
DiagnosticScopeFactory clientDiagnostics = new DiagnosticScopeFactory("Azure.Clients", "Microsoft.Azure.Core.Cool.Tests", true);

DiagnosticScope scope = clientDiagnostics.CreateScope("ActivityName");

var expectedTags = new Dictionary<string, string>()
{
{"key1", "value1"},
{"key2", "value2"}
};

scope.AddLink("id", expectedTags);
scope.Start();

(string Key, object Value, DiagnosticListener) startEvent = testListener.Events.Dequeue();

scope.Dispose();

(string Key, object Value, DiagnosticListener) stopEvent = testListener.Events.Dequeue();

Assert.Null(Activity.Current);
Assert.AreEqual("ActivityName.Start", startEvent.Key);
Assert.AreEqual("ActivityName.Stop", stopEvent.Key);

var activities = (IEnumerable<Activity>)startEvent.Value.GetType().GetProperty("Links").GetValue(startEvent.Value);
Activity linkedActivity = activities.Single();

Assert.AreEqual(ActivityIdFormat.W3C, linkedActivity.IdFormat);
Assert.AreEqual("id", linkedActivity.ParentId);

CollectionAssert.AreEquivalent(expectedTags, linkedActivity.Tags);
}

[Test]
public void FailedStopsActivityAndWritesExceptionEvent()
{
Expand Down