Skip to content

Improve performance by pre-encoding JSON property names in serializer #10284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maririos merged 2 commits into from
Mar 4, 2020
Merged

Improve performance by pre-encoding JSON property names in serializer #10284

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a6cbec
Improve performance by pre-encoding JSON property names in serializer
Marusyk Mar 3, 2020
146693b
Code review fixes
Marusyk Mar 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions sdk/textanalytics/Azure.AI.TextAnalytics/src/TextAnalyticsServiceSerializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ internal static class TextAnalyticsServiceSerializer

#region Serialize Inputs

private static readonly JsonEncodedText s_countryHint = JsonEncodedText.Encode("countryHint");
private static readonly JsonEncodedText s_id = JsonEncodedText.Encode("id");
private static readonly JsonEncodedText s_text = JsonEncodedText.Encode("text");
private static readonly JsonEncodedText s_language = JsonEncodedText.Encode("language");

public static ReadOnlyMemory<byte> SerializeDetectLanguageInputs(IEnumerable<DetectLanguageInput> inputs, string defaultCountryHint)
{
var writer = new ArrayBufferWriter<byte>();
Expand All @@ -27,9 +32,9 @@ public static ReadOnlyMemory<byte> SerializeDetectLanguageInputs(IEnumerable<Det
foreach (var input in inputs)
{
json.WriteStartObject();
json.WriteString("countryHint", input.CountryHint ?? defaultCountryHint);
json.WriteString("id", input.Id);
json.WriteString("text", input.Text);
json.WriteString(s_countryHint, input.CountryHint ?? defaultCountryHint);
json.WriteString(s_id, input.Id);
json.WriteString(s_text, input.Text);
json.WriteEndObject();
}
json.WriteEndArray();
Expand All @@ -47,9 +52,9 @@ public static ReadOnlyMemory<byte> SerializeDocumentInputs(IEnumerable<TextDocum
foreach (var input in inputs)
{
json.WriteStartObject();
json.WriteString("language", input.Language ?? defaultLanguage);
json.WriteString("id", input.Id);
json.WriteString("text", input.Text);
json.WriteString(s_language, input.Language ?? defaultLanguage);
json.WriteString(s_id, input.Id);
json.WriteString(s_text, input.Text);
json.WriteEndObject();
}
json.WriteEndArray();
Expand Down