Skip to content

[EventHubs] Distributed Tracing: add enqueueTime to Process span links (Track Two) #10227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kinelski merged 2 commits into from
Mar 2, 2020
Merged

[EventHubs] Distributed Tracing: add enqueueTime to Process span links (Track Two) #10227

kinelski merged 2 commits into from
Mar 2, 2020

Conversation

@kinelski
Copy link
Contributor

@kinelski kinelski commented Feb 29, 2020 •
edited
Loading

Fixes #9633.

  • On processing spans, added the newly defined enqueued time attribute.
  • Updated tests accordingly. The processor diagnostics test is currently flagged as Ignored due to instability during nightly runs, but it ran just fine locally.

@kinelski kinelski added Event Hubs Client This issue is related to a non-management package labels Feb 29, 2020
@kinelski kinelski added this to the [2020] March milestone Feb 29, 2020
@kinelski kinelski self-assigned this Feb 29, 2020
@kinelski kinelski marked this pull request as ready for review March 2, 2020 20:03
@kinelski kinelski requested a review from pakrym March 2, 2020 20:04
jsquire
jsquire approved these changes Mar 2, 2020
View reviewed changes
Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kinelski kinelski merged commit eea8410 into Azure:master Mar 2, 2020
@kinelski kinelski deleted the processingTime branch March 2, 2020 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsquire jsquire jsquire approved these changes

@serkantkaraca serkantkaraca Awaiting requested review from serkantkaraca

+1 more reviewer

@pakrym pakrym pakrym approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kinelski kinelski

Labels

Client This issue is related to a non-management package Event Hubs

Projects

None yet

Milestone

[2020] March

Development

Successfully merging this pull request may close these issues.

Distributed tracing for EventHubs: add enqueueTime to Process span links

3 participants

@kinelski @jsquire @pakrym