Adding LTR for MI to .NET SDK#10129
Merged
Merged
Conversation
isra-fel
added
Mgmt
isra-fel
requested changes
Feb 25, 2020
Member
isra-fel
left a comment
isra-fel
left a comment
There was a problem hiding this comment.
Hi @xaliciayang , it failed to build because some of the models could not be found, e.g. ManagedInstanceLongTermRetentionBackup. Did you forget to check in them?
Besides, please
- add link(s) to the swagger spec review in this PR's description
- check in the metadata txt of your module under
/eng/mgmt/mgmtmetadata
Detailed process guide: https://github.com/Azure/adx-documentation-pr/blob/master/engineering/adx_netsdk_process.md#generating-net-sdk
Contributor
Author
|
Added the missing models (also added many unrelated files in attempt to sync local repo). Will remove out-of-scope files Here is the swagger PR: Azure/azure-rest-api-specs#8266 |
xaliciayang
force-pushed
the
ayang_net
branch
from
6b46f8c to
21aea9f
Compare
pixia
reviewed
Feb 28, 2020
pixia
reviewed
Feb 28, 2020
pixia
reviewed
Feb 28, 2020
Contributor
There was a problem hiding this comment.
are we ok to expose test endpoint?
xaliciayang
force-pushed
the
ayang_net
branch
2 times, most recently
from
d3334d6 to
dd81843
Compare
jaredmoo
reviewed
Mar 2, 2020
xaliciayang
requested review from
AlexGhiondea,
KrzysztofCwalina,
arv100kri,
bitsforthought,
bleroy,
chidozieononiwu,
danieljurek,
jsquire and
kinelski
as code owners
xaliciayang
commented
Mar 3, 2020
| new Tuple<string, string, string>("Sql", "RestorePoints", "2017-03-01-preview"), | ||
| new Tuple<string, string, string>("Sql", "SensitivityLabels", "2017-03-01-preview"), | ||
| new Tuple<string, string, string>("Sql", "ServerAutomaticTuning", "2017-03-01-preview"), | ||
| new Tuple<string, string, string>("Sql", "ServerAzureADAdministrators", "2014-04-01"), |
Contributor
Author
There was a problem hiding this comment.
@amolagar should I revert this and leave it to you?
pixia
reviewed
Mar 3, 2020
| /// <exception cref="System.ArgumentNullException"> | ||
| /// Thrown when a required parameter is null | ||
| /// </exception> | ||
| public SqlManagementClient(ServiceClientCredentials credentials, HttpClient httpClient, bool disposeHttpClient) : this(httpClient, disposeHttpClient) |
pixia
reviewed
Mar 3, 2020
| /// </param> | ||
| /// <param name='disposeHttpClient'> | ||
| /// True: will dispose the provided httpClient on calling SqlManagementClient.Dispose(). False: will not dispose provided httpClient</param> | ||
| protected SqlManagementClient(HttpClient httpClient, bool disposeHttpClient) : base(httpClient, disposeHttpClient) |
pixia
reviewed
Mar 3, 2020
| new Tuple<string, string, string>("Sql", "Usages", "2018-06-01-preview"), | ||
| new Tuple<string, string, string>("Sql", "VirtualClusters", "2015-05-01-preview"), | ||
| new Tuple<string, string, string>("Sql", "VirtualNetworkRules", "2015-05-01-preview"), | ||
| new Tuple<string, string, string>("Sql", "WorkloadClassifiers", "2019-06-01-preview"), |
pixia
approved these changes
Mar 3, 2020
isra-fel
reviewed
Mar 3, 2020
…/Microsoft.Azure.Management.Sql.csproj
isra-fel
approved these changes
Mar 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding clients + test file for Managed Instance Long Term Retention Tests