Added Exists(), CreateIfNotExists(), and DeleteIfExists() to ShareCli… #10074
Conversation
…ent, FileClient, and DirectoryClient
|
@tg-msft, I'm thinking maybe we could potentially start grouping our optional parameters in this PR. What do you think? |
seanmcc-msft
requested review from
JoshLove-msft,
KrzysztofCwalina,
amnguye,
pakrym and
tg-msft
as code owners
| } | ||
| #endregion Create | ||
|
|
||
| #region Create If Not Exists |
There was a problem hiding this comment.
NIT - remove spaces. Also I believe for blobs, I put the CreateIfNotExists methods in the Create region
There was a problem hiding this comment.
Removed CreateIfNotExists per Ted's comment.
| } | ||
| #endregion Exists | ||
|
|
||
| #region Delete If Exists |
There was a problem hiding this comment.
NIT - Same thing I said about Create
There was a problem hiding this comment.
Renamed the region DeleteIfExists.
| Response<bool> existsResponse = await ExistsInternal( | ||
| async, | ||
| cancellationToken, | ||
| operationName).ConfigureAwait(false); | ||
|
|
||
| if (existsResponse.Value) | ||
| { | ||
| return null; | ||
| } | ||
| else | ||
| { | ||
| return await CreateInternal( | ||
| maxSize, | ||
| httpHeaders, | ||
| metadata, | ||
| smbProperties, | ||
| filePermission, | ||
| conditions, | ||
| async, | ||
| cancellationToken, | ||
| operationName) | ||
| .ConfigureAwait(false); | ||
| } |
There was a problem hiding this comment.
This will cause race conditions. It would be better to try the Create call and ignore errors if it already exists like you did for the directory client.
There was a problem hiding this comment.
https://docs.microsoft.com/en-us/rest/api/storageservices/create-file
I can't call Create an ignore errors, Create File overwrites existing files, and there are no conditional request headers. I think this might be the only way to do CreateIfNotExists for Files.
There was a problem hiding this comment.
Oh... yeah, that's kind of scary. We don't want to give people APIs they can't be successful with so I think we should only add Exists and DeleteIfExists for now for File Shares.
There was a problem hiding this comment.
Removed CreateIfNotExists from File Share.
3 participants
…ent, FileClient, and DirectoryClient