[Service Bus Client] Test Resources Tweaks#10009
Merged
jsquire merged 1 commit intoAzure:masterfrom Feb 17, 2020
Merged
Conversation
jsquire
added
Service Bus
Client
jsquire
requested review from
AlexGhiondea,
JoshLove-msft,
ShivangiReja,
danieljurek,
kinelski and
nemakam
The focus of these changes is to correct an issue with the test resources ARM template selecting an incorrect subscription for output, ensure the service principal has the contributor role, to allow make some small adjustments to template parameters.
jsquire
force-pushed
the
servicebus/tweak-testarm
branch
from
2bc5bc2 to
a6da992
Compare
JoshLove-msft
approved these changes
Feb 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The focus of these changes is to correct an issue with the test resources ARM template selecting an incorrect subscription for output, ensure the service principal has the contributor role, to allow make some small adjustments to template parameters.
Last Upstream Rebase
Monday, February 17, 10:47am (EST)