Skip to content

[Storage] QuickQuery - Make BlobQueryCsvTextConfiguration properties … #9484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
XiaoningLiu merged 1 commit into from
Jun 12, 2020
Merged

[Storage] QuickQuery - Make BlobQueryCsvTextConfiguration properties … #9484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdk/storage/storage-blob/review/storage-blob.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -769,10 +769,10 @@ export interface BlobProperties {

// @public
export interface BlobQueryCsvTextConfiguration extends BlobQueryTextConfiguration {
columnSeparator: string;
columnSeparator?: string;
escapeCharacter?: string;
fieldQuote?: string;
hasHeaders: boolean;
hasHeaders?: boolean;
kind: "csv";
}

Expand Down
10 changes: 5 additions & 5 deletions sdk/storage/storage-blob/src/Clients.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2734,12 +2734,12 @@ export interface BlobQueryCsvTextConfiguration extends BlobQueryTextConfiguratio
*/
kind: "csv";
/**
* Column separator.
* Column separator. Default is ",".
*
* @type {string}
* @memberof BlobQueryCsvTextConfiguration
*/
columnSeparator: string;
columnSeparator?: string;
/**
* Field quote.
*
Expand All @@ -2755,12 +2755,12 @@ export interface BlobQueryCsvTextConfiguration extends BlobQueryTextConfiguratio
*/
escapeCharacter?: string;
/**
* Has headers.
* Has headers. Default is false.
*
* @type {boolean}
* @memberof BlobQueryCsvTextConfiguration
*/
hasHeaders: boolean;
hasHeaders?: boolean;
}

/**
Expand Down Expand Up @@ -3445,7 +3445,7 @@ export class BlockBlobClient extends BlobClient {
): Promise<BlobDownloadResponseModel> {
ensureCpkIfSpecified(options.customerProvidedKey, this.isHttps);

const { span, spanOptions } = createSpan("BlobClient-query", options.tracingOptions);
const { span, spanOptions } = createSpan("BlockBlobClient-query", options.tracingOptions);

try {
const response = await this._blobContext.query({
Expand Down
4 changes: 2 additions & 2 deletions sdk/storage/storage-blob/src/utils/utils.common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,11 +576,11 @@ export function toQuerySerialization(
format: {
type: "delimited",
delimitedTextConfiguration: {
columnSeparator: textConfiguration.columnSeparator,
columnSeparator: textConfiguration.columnSeparator || ",",
fieldQuote: textConfiguration.fieldQuote || "",
recordSeparator: textConfiguration.recordSeparator,
escapeChar: textConfiguration.escapeCharacter || "",
headersPresent: textConfiguration.hasHeaders
headersPresent: textConfiguration.hasHeaders || false
}
}
};
Expand Down