Skip to content

[Cosmos] Use constants for auth headers returned by generateHeaders function #9354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
southpolesteve merged 2 commits into from
Jun 8, 2020
Merged

[Cosmos] Use constants for auth headers returned by generateHeaders function #9354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed681ec
[Cosmos] Use constants for auth headers returned by generateHeaders f…
southpolesteve Jun 7, 2020
c87ba93
Update changelog
southpolesteve Jun 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sdk/cosmosdb/cosmos/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
# Release History

## 3.7.0 (Unreleased)
## 3.7.0 (2020-6-08)

- BUGFIX: Support crypto functions in Internet Explorer browser
- BUGFIX: Incorrect key casing in object returned by `setAuthorizationHeader`
- FEATURE: Adds `readOffer` methods to container and database
- FEATURE: Allows string value `partitionKey` parameter when creating containers

Expand Down
6 changes: 3 additions & 3 deletions sdk/cosmosdb/cosmos/src/utils/headers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { hmac } from "./hmac";
import { HTTPMethod, ResourceType } from "../common";
import { HTTPMethod, ResourceType, Constants } from "../common";

export async function generateHeaders(
masterKey: string,
Expand All @@ -11,8 +11,8 @@ export async function generateHeaders(
const sig = await signature(masterKey, method, resourceType, resourceId, date);

return {
Authorization: sig,
"x-ms-date": date.toUTCString()
[Constants.HttpHeaders.Authorization]: sig,
[Constants.HttpHeaders.XDate]: date.toUTCString()
};
}

Expand Down