Skip to content

[core-http] Remove unused dev dependency "ts-loader"#9309

Merged
mikeharder merged 1 commit intoAzure:masterfrom
mikeharder:core-http-ts-loader
Jun 4, 2020
Merged

[core-http] Remove unused dev dependency "ts-loader"#9309
mikeharder merged 1 commit intoAzure:masterfrom
mikeharder:core-http-ts-loader

Conversation

@mikeharder
Copy link
Copy Markdown
Member

@mikeharder mikeharder commented Jun 4, 2020

Dev dependency ts-loader appears to be unused. The only package which depends on it is core-http, and there are no other references to ts-loader in package.json or the source code.

https://github.com/Azure/azure-sdk-for-js/search?q=ts-loader&unscoped_q=ts-loader

@mikeharder mikeharder marked this pull request as ready for review June 4, 2020 21:15
@mikeharder mikeharder added EngSys This issue is impacting the engineering system. Client This issue points to a problem in the data-plane of the library. labels Jun 4, 2020
@daviwil
Copy link
Copy Markdown
Contributor

daviwil commented Jun 4, 2020

Looks like this was missed when removing webpack as a dependency of core-http. Looks good, thanks!

@mikeharder mikeharder merged commit 12d22b9 into Azure:master Jun 4, 2020
@mikeharder mikeharder deleted the core-http-ts-loader branch June 4, 2020 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants