[KeyVault Certificates] v4.0.2 hotfix for #9005 and #9020#9122
Merged
sadasant merged 5 commits intoAzure:hotfix/keyvault-challengeAuth-certificates-from-4.0.0from Jun 1, 2020
Conversation
Contributor
Author
1c21b18 to
06ca42e
Compare
Contributor
Author
|
/check-enforcer evaluate |
KarishmaGhiya
approved these changes
May 27, 2020
KarishmaGhiya
approved these changes
May 27, 2020
Member
|
/check-enforcer evaluate |
sophiajt
approved these changes
Jun 1, 2020
f5ec03c
into
Azure:hotfix/keyvault-challengeAuth-certificates-from-4.0.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
@azure/keyvault-certificatesto version4.0.2. It includes a fix for the issue #9005, which consists in ensuring that parallel requests load the already cached credentials appropriately, and a fix for the issue #9020, which consists on ensuring that theupdateCertificatePropertiesmethod correctly uses the certificate attributes.I'm using the same base branch as the one used for the previous hotfix (4.0.1): https://github.com/Azure/azure-sdk-for-js/tree/hotfix/keyvault-challengeAuth-certificates-from-4.0.0
The fixes in greater detail are:
For the issue #9005
PR to master #9059
The recent hotfix showed an outstanding bug now that the cache is working correctly: Multiple async requests running at the same time quickly fail rather than re-using the credentials of the first authenticated.
This fix ensures that anytime we receive a response that indicates that authentication is necessary we update the original request with the available credentials and send it again, even if we already had a valid token and challenge in memory.
I also refactored the logic to make it easier to follow, so that future changes can be made more straightforwardly.
For the issue #9020
PR to master #9135
The bug is that updateCertificateProperties is not correctly passing the attributes required by the underlying method.
The fix I'm making is to change the
updateCertificatePropertiesmethod to correctly set the certificateAttributes in the options bag that is passed to the generatedupdateCertificatemethod: