Skip to content

[FormRecognizer] rename parameter name of *FromUrl() methods #9118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremymeng merged 1 commit into from
May 26, 2020
Merged

[FormRecognizer] rename parameter name of *FromUrl() methods #9118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions sdk/formrecognizer/ai-form-recognizer/review/ai-form-recognizer.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,11 +202,11 @@ export type FormPollerLike = PollerLike<PollOperationState<RecognizeFormResultRe
export class FormRecognizerClient {
constructor(endpointUrl: string, credential: TokenCredential | KeyCredential, options?: FormRecognizerClientOptions);
beginRecognizeContent(data: FormRecognizerRequestBody, contentType?: ContentType, options?: BeginRecognizeContentOptions): Promise<ContentPollerLike>;
beginRecognizeContentFromUrl(formFileUrl: string, options?: BeginRecognizeContentOptions): Promise<ContentPollerLike>;
beginRecognizeContentFromUrl(formUrl: string, options?: BeginRecognizeContentOptions): Promise<ContentPollerLike>;
beginRecognizeCustomForms(modelId: string, data: FormRecognizerRequestBody, contentType?: ContentType, options?: BeginRecognizeFormsOptions): Promise<FormPollerLike>;
beginRecognizeCustomFormsFromUrl(modelId: string, formFileUrl: string, options?: BeginRecognizeFormsOptions): Promise<PollerLike<PollOperationState<RecognizeFormResultResponse>, RecognizeFormResultResponse>>;
beginRecognizeCustomFormsFromUrl(modelId: string, formUrl: string, options?: BeginRecognizeFormsOptions): Promise<PollerLike<PollOperationState<RecognizeFormResultResponse>, RecognizeFormResultResponse>>;
beginRecognizeReceipts(data: FormRecognizerRequestBody, contentType?: ContentType, options?: BeginRecognizeReceiptsOptions): Promise<ReceiptPollerLike>;
beginRecognizeReceiptsFromUrl(receiptFileUrl: string, options?: BeginRecognizeReceiptsOptions): Promise<ReceiptPollerLike>;
beginRecognizeReceiptsFromUrl(receiptUrl: string, options?: BeginRecognizeReceiptsOptions): Promise<ReceiptPollerLike>;
readonly endpointUrl: string;
getFormTrainingClient(): FormTrainingClient;
}
Expand Down
18 changes: 9 additions & 9 deletions sdk/formrecognizer/ai-form-recognizer/src/formRecognizerClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,12 +343,12 @@ export class FormRecognizerClient {
* console.log(response.pages);
* ```
* @summary Recognizes content/layout information from a url to a form document
* @param {string} formFileUrl Url to an accessible form document
* @param {string} formUrl Url to an accessible form document
ng", and "image/tiff";
* @param {BeginRecognizeContentOptions} [options] Options to start content recognition operation
*/
public async beginRecognizeContentFromUrl(
formFileUrl: string,
formUrl: string,
options: BeginRecognizeContentOptions = {}
): Promise<ContentPollerLike> {
const analyzePollerClient: RecognizePollerClient<RecognizeContentResultResponse> = {
Expand All @@ -358,7 +358,7 @@ ng", and "image/tiff";

const poller = new BeginRecognizePoller<RecognizeContentResultResponse>({
client: analyzePollerClient,
source: formFileUrl,
source: formUrl,
contentType: undefined,
...options
});
Expand Down Expand Up @@ -477,13 +477,13 @@ ng", and "image/tiff";
* ```
* @summary Recognizes form information from a url to a form document using a custom form model.
* @param {string} modelId Id of the custom form model to use
* @param {string} formFileUrl Url to an accessible form document
* @param {string} formUrl Url to an accessible form document
ng", and "image/tiff";
* @param {BeginRecognizeFormsOptions} [options] Options to start the form recognition operation
*/
public async beginRecognizeCustomFormsFromUrl(
modelId: string,
formFileUrl: string,
formUrl: string,
options: BeginRecognizeFormsOptions = {}
): Promise<
PollerLike<PollOperationState<RecognizeFormResultResponse>, RecognizeFormResultResponse>
Expand All @@ -505,7 +505,7 @@ ng", and "image/tiff";
const poller = new BeginRecognizePoller({
client: analyzePollerClient,
modelId,
source: formFileUrl,
source: formUrl,
contentType: undefined,
...options
});
Expand Down Expand Up @@ -637,11 +637,11 @@ ng", and "image/tiff";
* console.log(usReceipt.recognizedForm.fields["MerchantAddress"]);
* ```
* @summary Recognizes receipt information from a given accessible url to input document
* @param {string} receiptFileUrl url to the input receipt document
* @param {string} receiptUrl url to the input receipt document
* @param {BeginRecognizeReceiptsOptions} [options] Options to start receipt recognition operation
*/
public async beginRecognizeReceiptsFromUrl(
receiptFileUrl: string,
receiptUrl: string,
options: BeginRecognizeReceiptsOptions = {}
): Promise<ReceiptPollerLike> {
const analyzePollerClient: RecognizePollerClient<RecognizeReceiptResultResponse> = {
Expand All @@ -651,7 +651,7 @@ ng", and "image/tiff";

const poller = new BeginRecognizePoller({
client: analyzePollerClient,
source: receiptFileUrl,
source: receiptUrl,
contentType: undefined,
...options
});
Expand Down