replace relative link in the root readme too #6663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KarishmaGhiya
changed the title
KarishmaGhiya
requested review from
danieljurek,
mikeharder and
mitchdenny
as code owners
weshaggard
reviewed
Dec 20, 2019
KarishmaGhiya
force-pushed
the
contributingGuide
branch
from
6634c04 to
9ff7569
Compare
KarishmaGhiya
force-pushed
the
contributingGuide
branch
from
9ff7569 to
f7c4b5c
Compare
weshaggard
approved these changes
Jan 6, 2020
Member
|
@KarishmaGhiya once this gets merged can you please queue a doc index build so we can get it refreshed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for issue - #6323
The contributing link was not resolved to complete path since we are scoping the script to run within a service folder. But for links which are in the root readme, we will have to run in the entire repo. The downside though is that the script also picks up other READMEs which are in the node-modules folder(s) of packages under
/common/temp/pnpm-store/2/registry.npmjs.org/Reference - https://dev.azure.com/azure-sdk/public/_build/results?buildId=216691&view=logs&j=3dc8fd7e-4368-5a92-293e-d53cefc8c4b3&t=9a4ddc9a-5b6e-5495-335e-b34e54a89692
cc: @weshaggard @scbedd