[event-hubs] Better error handling and reporting#6465
Merged
richardpark-msft merged 9 commits intoDec 10, 2019
Merged
Conversation
* claimOwnership() errors during load balancing are routed to the user's processError handler * claimOwnership() errors when stopping are thrown Also: * Fixing a bug where we weren't awaiting when abandoning partitions. * Moving the abandonPartitions to the end, rather than the beginning of stop()
* Also updating dep info for eventhubs-checkpointstore-blob which won't work properly if ran against an older eventhubs package.
* processError() errors are logged, but ignored
Member
Author
|
/azp run js - eventhubs-client - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
chradek
reviewed
Dec 9, 2019
… from underneath us.
chradek
approved these changes
Dec 9, 2019
…dn't claim any. Prior to this change we couldn't tell the difference between "storage is failing for some reason" and "we're just losing to other processors that are attempting to claim partitions". Now an empty list of ownerships is okay and just indicates that we should do nothing this time around.
Member
Author
|
/azp run js - eventhubs-client - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
chradek
approved these changes
Dec 10, 2019
Contributor
chradek
left a comment
chradek
left a comment
There was a problem hiding this comment.
Latest changes look good to me. I see there's still one flaky test but I wouldn't let it block since we already have an issue tracking it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to error handling and reporting due to feature team discussion.
processClose) throw errors we funnel those into their processError()
handler so they'll know about it.
Now, the only case where it will eat errors is when we have an etag
conflict due to someone else taking partition ownership.
Fixes #6444