[Storage] Add more tests covering progress events#6428
Merged
Conversation
jeremymeng
added
Client
jeremymeng
requested review from
HarshaNalluru,
XiaoningLiu,
jiacfan and
vinjiang
as code owners
jeremymeng
commented
Dec 5, 2019
jeremymeng
changed the title
jeremymeng
force-pushed
the
stage-block-onprogress
branch
from
b7752b8 to
e21d82b
Compare
Member
|
@jiacfan Any comments here? |
jiacfan
reviewed
Dec 10, 2019
|
|
||
| const content = "Hello World!"; | ||
| await appendBlobClient.appendBlock(content, content.length, { | ||
| onProgress: () => {} |
Member
There was a problem hiding this comment.
minor: The PR enhanced the coverage, and is a great work! One question is, most of the test use empty callbacks, is that by design? Possibly, we may change at least one of them to be a useful callback, so we can validate the callback itself works.
Member
Author
There was a problem hiding this comment.
Even the body is empty, the callback is invoked. I've verified that before the fix these test failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #6352.