[event-hubs] Updating samples folder to make it a standalone project#6413
Merged
richardpark-msft merged 15 commits intoDec 10, 2019
Merged
Conversation
* Makes it simpler for users to just download the entire folder, npm install and run. * Makes it more effective for us as a testing tool since we can use it to test whatever is published.
richardpark-msft
requested review from
bterlson,
chradek,
daviwil,
jeremymeng,
joheredi,
ramya-rao-a,
ramya0820,
sarangan12,
willmtemple and
xirzec
Member
Author
|
@willmtemple - I think you've got the most experience on this. Let's talk when you get back about what I should do here. |
willmtemple
reviewed
Dec 9, 2019
…iple events over several batches.
…sample a bit more readable. * Moved the import and the call to the bottom to make it more obvious which parts are "this is sample stuff" and which parts are "this is the code that you want to use"
… environment variables get initialized before the sample runs.
Member
Author
|
@chradek / @ramya-rao-a - looks like @willmtemple is okay with the changes. Mind approving this if you're okay with it as well? For the most part it's just changes to make the samples standalone. I did update sendEvents.ts with @ramya-rao-a 's suggested logic (but without the recursion). |
willmtemple
approved these changes
Dec 10, 2019
Contributor
willmtemple
left a comment
willmtemple
left a comment
There was a problem hiding this comment.
Cool. Let's merge this and I'll do the readme metadata in a separate PR after I merge some changes to storage.
chradek
reviewed
Dec 10, 2019
* Adding in @types/node
…nce we're using ts-node for the running)
chradek
approved these changes
Dec 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improving the samples by making them:
dotenv.Also, made an improvement to the sendEvents.ts example, fixing #6254