Merged
Conversation
ghost
added
ghost
requested review from
kpajdzik
reviewed
Nov 28, 2018
package.json
Outdated
| "fs": "0.0.1-security", | ||
| "gulp": "^3.9.1", | ||
| "fs": "^0.0.1-security", | ||
| "gulp": "^4.0.0", |
Contributor
There was a problem hiding this comment.
I remember there were some problems with Gulp 4.0 (Do you remember when you reverted my Gulp update?). Have you verified it works?
Author
There was a problem hiding this comment.
That sounds familiar, but I guess we'll see if it works if the CI passes.
Contributor
There was a problem hiding this comment.
I don't think it will show up in CI tests. I believe it was hanging when running some gulp tasks.
kpajdzik
approved these changes
Nov 28, 2018
added 9 commits
November 28, 2018 11:33
HarshaNalluru
pushed a commit
to HarshaNalluru/azure-sdk-for-js
that referenced
this pull request
Apr 12, 2019
Update dependencies
sarangan12
pushed a commit
to sarangan12/azure-sdk-for-js
that referenced
this pull request
Jul 14, 2020
[v6] improve request multi-mediatype support
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.