Skip to content

Run prettier on all files in core-http#5445

Merged
ramya-rao-a merged 1 commit into
Azure:masterfrom
ramya-rao-a:format-core-http
Oct 9, 2019
Merged

Run prettier on all files in core-http#5445
ramya-rao-a merged 1 commit into
Azure:masterfrom
ramya-rao-a:format-core-http

Conversation

@ramya-rao-a
Copy link
Copy Markdown
Contributor

@ramya-rao-a ramya-rao-a commented Oct 8, 2019

Every time we make any changes to core-http, we have a series of changes unrelated to the feature/bug-fix and more around formatting.

This PR runs prettier on all files in core-http to avoid such occurrences in the future

Note to reviewer:

  • Check if the addition/removal of brackets are not causing any change in expected behavior
  • Ignore the changes to the test files, the CI should catch any issues caused there.

@ramya-rao-a ramya-rao-a requested a review from daviwil as a code owner October 8, 2019 01:44
Copy link
Copy Markdown
Contributor

@daviwil daviwil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I had avoided using a formatter on the code for a while so it'd be easier to migrate changes between this and ms-rest-js, but I think it's safe to go ahead now!

value = value instanceof Date ? value.toUTCString() : new Date(value).toUTCString();
} else if (typeName.match(/^UnixTime$/gi) !== null) {
if (
!(
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Freaky formatting

@ramya-rao-a ramya-rao-a merged commit 96de036 into Azure:master Oct 9, 2019
@ramya-rao-a ramya-rao-a deleted the format-core-http branch October 9, 2019 00:01
aditishree1 pushed a commit that referenced this pull request Apr 6, 2026
Implements the Semantic Rerank feature (ported from .NET SDK PR #5445) that
enables users to rerank documents using the Cosmos DB Inference Service for
semantic relevance scoring.

New features:
- Container.semanticRerank() public method for reranking documents
- InferenceService internal class managing HTTP calls to inference endpoint
- SemanticRerankResult, RerankScore, and SemanticRerankOptions types
- inferenceEndpoint option in CosmosClientOptions
- Separate AAD-authenticated pipeline with inference scope

The inference service uses a dedicated HTTP pipeline with its own AAD scope
(https://dbinference.azure.com/.default) and does not share the main SDK
request pipeline or retry policies.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants