Skip to content

Change gulpfile to TypeScript, update SwaggerToSDK generator version#5

Merged
2 commits merged intomasterfrom
daschult/tsGulp
Sep 17, 2018
Merged

Change gulpfile to TypeScript, update SwaggerToSDK generator version#5
2 commits merged intomasterfrom
daschult/tsGulp

Conversation

@ghost
Copy link

@ghost ghost commented Sep 17, 2018

No description provided.

@ghost ghost added this to the Sprint-124 milestone Sep 17, 2018
@ghost ghost self-assigned this Sep 17, 2018
@ghost ghost requested review from RikkiGibson, amarzavery and kpajdzik September 17, 2018 21:28
@ghost ghost added the in progress label Sep 17, 2018
gulpfile.ts Outdated

function npmInstall(packageFolderPath) {
execSync(`npm install`, { cwd: packageFolderPath, stdio: ['ignore', 'ignore', 'pipe'] });
function npmInstall(packageFolderPath: string): any {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this return type used now?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. I added it just so that npmInstall() behaved a little more like execSync(), but since I wasn't using it I'll just make it void.

@ghost ghost merged commit e26f3fc into master Sep 17, 2018
@ghost ghost deleted the daschult/tsGulp branch September 17, 2018 22:09
@ghost ghost removed the in progress label Sep 17, 2018
HarshaNalluru referenced this pull request in HarshaNalluru/azure-sdk-for-js Apr 12, 2019
Change gulpfile to TypeScript, update SwaggerToSDK generator version
HarshaNalluru referenced this pull request in HarshaNalluru/azure-sdk-for-js Apr 12, 2019
Initial PR for Azure SB over amqp
ramya0820 pushed a commit to ramya0820/azure-sdk-for-js that referenced this pull request May 1, 2019
renamed methods and added IotHubConnectionConfig
bterlson pushed a commit to bterlson/azure-sdk-for-js that referenced this pull request May 24, 2019
fixing moment dependency strictly to 2.18.1
daviwil pushed a commit to daviwil/azure-sdk-for-js that referenced this pull request Jun 7, 2019
Rename bodyAsJson to parsedBody
ramya-rao-a referenced this pull request in ramya-rao-a/azure-sdk-for-js Aug 23, 2019
[Event Hubs] Improve docs based on ux study
sarangan12 referenced this pull request in sarangan12/azure-sdk-for-js Jul 14, 2020
Update autorest.typescript.csproj
sarangan12 referenced this pull request in sarangan12/azure-sdk-for-js Jul 14, 2020
KarishmaGhiya pushed a commit that referenced this pull request Sep 28, 2023
# This is the 1st commit message:

fix test for IBC

# This is the commit message #2:

[identity] Update MSAL to use its own open browser

# This is the commit message #3:

update open browser code

# This is the commit message #5:

formatting
KarishmaGhiya pushed a commit that referenced this pull request Oct 2, 2023
# This is the 1st commit message:

fix test for IBC

# This is the commit message #2:

[identity] Update MSAL to use its own open browser

# This is the commit message #3:

update open browser code

# This is the commit message #5:

formatting
KarishmaGhiya pushed a commit that referenced this pull request Oct 10, 2023
# This is the 1st commit message:

fix test for IBC

# This is the commit message #2:

[identity] Update MSAL to use its own open browser

# This is the commit message #3:

update open browser code

# This is the commit message #5:

formatting
deyaaeldeen added a commit that referenced this pull request Mar 6, 2026
- Fix __dirname usage in ESM test: derive from import.meta.url (#1)
- Add .catch() handler on main() for deterministic error exit (#2)
- Fail closed on truncated fork PR patches: track truncatedPatchKeys in
  validateInput and flag them as dependency-poisoning in detectSuspiciousPR (#3)
- Separate stdout/stderr in workflow: remove 2>&1 so stderr goes to job
  log and stdout stays clean JSON for jq parsing (#4)
- Drop tsx dependency: use node --experimental-strip-types with
  erasableSyntaxOnly + allowImportingTsExtensions, switch all imports
  from .js to .ts extensions (#5)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant