Make @azure/app-configuration README conformant with docwarden#4782
Merged
daviwil merged 1 commit intoAzure:masterfrom Aug 16, 2019
Merged
Make @azure/app-configuration README conformant with docwarden#4782daviwil merged 1 commit intoAzure:masterfrom
daviwil merged 1 commit intoAzure:masterfrom
Conversation
Contributor
Author
|
@mikeharder @danieljurek -- Do you know what else I need to do to have the We may also need a folder-specific pipeline config for |
Contributor
Author
|
/azp run js - client - ci |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Contributor
Author
|
/azp run js - client |
|
No pipelines are associated with this pull request. |
mikeharder
approved these changes
Aug 16, 2019
daviwil
force-pushed
the
fix-app-config-readme
branch
from
10ac468 to
071c720
Compare
daviwil
force-pushed
the
fix-app-config-readme
branch
from
071c720 to
1dd280e
Compare
Contributor
Author
|
After speaking with @danieljurek, I've decided to remove the Analyze phase passed in this CI run, I think that's sufficient to verify that the README.md fix was successful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes a build break caused by PR #4753. Apparently that PR was treated as a management plane library so the CI run did not run these README checks. I'm also adding the changes necessary to have the
js - clientCI pipeline run for it.