[core-http] Reintroduce ServiceClientCredentials as an accepted credential type#4773
Merged
daviwil merged 5 commits intoAzure:masterfrom Aug 16, 2019
Merged
Conversation
daviwil
requested review from
ShivangiReja,
sadasant and
sophiajt
as code owners
sophiajt
approved these changes
Aug 15, 2019
Contributor
Author
|
Also added a fix that removes some unneeded methods in |
ramya-rao-a
reviewed
Aug 16, 2019
| export interface AbortSignalLike { | ||
| readonly aborted: boolean; | ||
| dispatchEvent: (event: Event) => boolean; | ||
| onabort: ((this: AbortSignalLike, ev: Event) => any) | null; |
Contributor
There was a problem hiding this comment.
Why are we still defining AbortSignalLike incore-http instead of using it from abort-controller?
Contributor
Author
There was a problem hiding this comment.
I left it mainly to avoid potentially sidespread changes for the interface import but it seems quite minimal. I've updated the PR to re-export AbortSignalLike from @azure/abort-controller.
ramya-rao-a
approved these changes
Aug 16, 2019
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change reintroduces the
ServiceClientCredentialsinterface as an accepted credential type forServiceClientclasses. This is necessary because libraries like @azure/app-configuration and the various Cognitive Services libraries need to use their own custom (non-AAD) authentication schemes. Without this change, users of those libraries would have to construct their own RequestPolicy pipeline just so that thesigningPolicycan be used.Since this affects a bunch of libraries I went ahead and bumped the core dependency versions of our various libraries so that everything is up to date (@chradek, this will affect your tracing PR).