Skip to content

Remove unused dev dependency rollup-plugin-resolve#4770

Merged
mikeharder merged 1 commit intoAzure:masterfrom
mikeharder:remove-rollup-plugin-resolve
Aug 15, 2019
Merged

Remove unused dev dependency rollup-plugin-resolve#4770
mikeharder merged 1 commit intoAzure:masterfrom
mikeharder:remove-rollup-plugin-resolve

Conversation

@mikeharder
Copy link
Member

No description provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, I could have sworn all of this stuff got removed in my most recent PR, but apparently it came along for the ride.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might have been added back by another PR if they didn't rebase before re-generating the lock file. I think it's best to think of the lockfile in terms of "eventual consistency". As long as nothing is broken with our packages or tests, it's OK if the lockfile is a bit outdated (which it usually is since new dependencies are released continuously).

@mikeharder mikeharder force-pushed the remove-rollup-plugin-resolve branch from 1f9f27c to 3347b4f Compare August 15, 2019 18:45
@mikeharder mikeharder merged commit c71fe51 into Azure:master Aug 15, 2019
@mikeharder mikeharder deleted the remove-rollup-plugin-resolve branch August 15, 2019 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants