[KeyVault] Updated path of the types to point to the correct directory

[michaelmcmillan]

Problem

When installing the keyvault-secrets package by typing yarn add @azure/keyvault-secrets and then trying to use it like this:

import { DefaultAzureCredential } from "@azure/identity";
import { SecretsClient } from "@azure/keyvault-secrets";

the tsc (TypeScript compiler) raises the following error:

Could not find a declaration file for module '@azure/keyvault-secrets'. 'node_modules/@azure/keyvault-secrets/dist/index.js' implicitly has an 'any'     type. Try `npm install @types/azure__keyvault-secrets` if it exists or add a new declaration (.d.ts) file containing `declare module '@azure/keyvault-secrets';`

What I think is causing this

This is not the correct path to the types: 8e3c933#diff-9cb805b9c2b8f9e19a3d3937d6a28ce2R51. Here is the tree of the types/src directory:

node_modules/@azure/keyvault-secrets/types/src
├── core
├── index.d.ts
├── index.d.ts.map
├── secretsModels.d.ts
└── secretsModels.d.ts.map

Suggested fix

Change the types parameter in package.json to point to the types/src/ so that it implicitly uses types/src/index.d.ts.

[sophiajt]

Thanks for raising this. The issue looks like the .d.ts file we're creating isn't getting properly put into the package. It should be getting built by API Extractor using the .d.ts files tsc produces. I'll look into this a bit further and see if I can work out why it's not running properly.

[sophiajt]

Filed #4720, which I think is the core issue here.

Thanks again for the report.

[michaelmcmillan]

My pleasure! I’ll keep an eye out on #4720. Thank you, Jonathan :)

…

On Thu, 8 Aug 2019 at 22:06, Jonathan Turner ***@***.***> wrote: Filed #4720 <#4720>, which I think is the core issue here. Thanks again for the report. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4716?email_source=notifications&email_token=AABD57JV4YHJHIYUFDXER2LQDR4FPA5CNFSM4IKKOTVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD34YEEY#issuecomment-519668243>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABD57K4MUNU7X3PLSNTV3DQDR4FPANCNFSM4IKKOTVA> .

[ramya-rao-a]

Thanks for bringing this to our attention @michaelmcmillan!

Closing this PR as we have now shipped an update for the keyvault-secrets library with the same fix from the PR #4722

[sadasant]

@michaelmcmillan Michael, being honest, I missed your PR. I think I was laser focused on the tasks I had. We do appreciate the time you put here. Please continue with your contributions!

Also, have a great weekend!

[michaelmcmillan]

No worries, thanks for responding so quickly!