[Identity] Update @azure/identity dependencies to use caret versions#4674
Merged
daviwil merged 1 commit intoAzure:masterfrom Aug 16, 2019
Merged
[Identity] Update @azure/identity dependencies to use caret versions#4674daviwil merged 1 commit intoAzure:masterfrom
daviwil merged 1 commit intoAzure:masterfrom
Conversation
mikeharder
requested changes
Aug 5, 2019
Member
mikeharder
left a comment
mikeharder
left a comment
There was a problem hiding this comment.
You probably need to run rush update --full to update pnpm-lock.yaml. I think we need the pnpm-lock.yaml updates for this change to have impact.
sdk/identity/identity/package.json
Outdated
Contributor
Author
|
Argh, thanks! I'll have to remember to run it like that every time it doesn't get updated when I expect it to. |
daviwil
force-pushed
the
fix-identity-deps
branch
from
373afa9 to
fb5d2c8
Compare
Contributor
Author
|
Strange build failure due to dependency upgrades, I'm looking into it. |
ramya-rao-a
approved these changes
Aug 6, 2019
daviwil
force-pushed
the
fix-identity-deps
branch
from
fb5d2c8 to
cbd3325
Compare
Member
|
@daviwil The Verify Readme step in the pipeline failed because the Readme content in /sdk/appconfiguration/app-configuration/README.md doesn't match the required guidelines for Readme. Has some missing headers. You can follow the steps to fix it here - aka.ms/azure-sdk-analyze-failed |
Contributor
Author
|
Ouch, sorry about that! Thanks for letting me know. |
daviwil
force-pushed
the
fix-identity-deps
branch
from
cbd3325 to
afc820c
Compare
mikeharder
approved these changes
Aug 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surprisingly there were no
pnpm-lock.yamlupdates after making these changes.Fixes #4673.