Skip to content

Add tracing to keyvault-keys library #4654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ramya-rao-a merged 17 commits into from
Aug 5, 2019
Merged

Add tracing to keyvault-keys library #4654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
6d74f87
Add tracing to keyvault-keys library
ramya-rao-a Aug 3, 2019
99bff0e
createSpan method
ramya-rao-a Aug 3, 2019
e2c529f
Update headers for all apis to allow serialization
ramya-rao-a Aug 4, 2019
3f319d9
Set the right parent when passing to service
ramya-rao-a Aug 5, 2019
6e55042
Comment for createSpan
ramya-rao-a Aug 5, 2019
139f4a3
Revert changes related to headers
ramya-rao-a Aug 5, 2019
192858b
Merge remote-tracking branch 'origin/master' into keys-tracing
ramya-rao-a Aug 5, 2019
ac84692
Add missing eol
ramya-rao-a Aug 5, 2019
53a6c66
End span if request throws error
ramya-rao-a Aug 5, 2019
64ea0ae
Remove method from span name
ramya-rao-a Aug 5, 2019
e09c2c3
Add plugin type to tracer interface
ramya-rao-a Aug 5, 2019
afb9cd5
Update Tracer NoImpl
ramya-rao-a Aug 5, 2019
80e05cd
Use readonly properties instead of getter
ramya-rao-a Aug 5, 2019
b763e9b
api update
ramya-rao-a Aug 5, 2019
0052bd1
Avoid updating spanoptions if noop tracer
ramya-rao-a Aug 5, 2019
dd75be3
Avoid updating spanoptions if no parent
ramya-rao-a Aug 5, 2019
1545c54
Merge remote-tracking branch 'origin/master' into keys-tracing
ramya-rao-a Aug 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions sdk/core/core-tracing/review/core-tracing.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export class NoOpTracePlugin implements Tracer {
// (undocumented)
getHttpTextFormat(): unknown;
// (undocumented)
readonly pluginType: SupportedPlugins;
readonly pluginType = SupportedPlugins.NOOP;
// (undocumented)
recordSpanData(span: Span): void;
// (undocumented)
Expand Down Expand Up @@ -124,7 +124,7 @@ export class OpenCensusTracePlugin implements Tracer {
// (undocumented)
getHttpTextFormat(): unknown;
// (undocumented)
readonly pluginType: SupportedPlugins;
readonly pluginType = SupportedPlugins.OPENCENSUS;
// (undocumented)
recordSpanData(span: Span): void;
// (undocumented)
Expand Down Expand Up @@ -250,7 +250,7 @@ export class TracerNoOpImpl implements Tracer {
// (undocumented)
getHttpTextFormat(): unknown;
// (undocumented)
readonly pluginType: SupportedPlugins;
readonly pluginType = SupportedPlugins.NOOP;
// (undocumented)
recordSpanData(span: Span): void;
// (undocumented)
Expand Down
1 change: 1 addition & 0 deletions sdk/keyvault/keyvault-keys/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@
"@azure/core-arm": "1.0.0-preview.2",
"@azure/core-http": "1.0.0-preview.2",
"@azure/core-paging": "1.0.0-preview.1",
"@azure/core-tracing": "1.0.0-preview.1",
"@azure/identity": "1.0.0-preview.2",
"tslib": "^1.9.3"
},
Expand Down
Loading