Skip to content

[Storage] Support SAS Connection String - storage-blob#4632

Merged
HarshaNalluru merged 11 commits intoAzure:feature/storagefrom
HarshaNalluru:SASConnStringBlob
Aug 2, 2019
Merged

[Storage] Support SAS Connection String - storage-blob#4632
HarshaNalluru merged 11 commits intoAzure:feature/storagefrom
HarshaNalluru:SASConnStringBlob

Conversation

@HarshaNalluru
Copy link
Contributor

@HarshaNalluru HarshaNalluru commented Aug 2, 2019

Storage service provides two types of connection strings, one with the accountname and key and the other one SAS conn. string with SAS string and endpoints.

This PR adds the SAS connection string support to the existing connection string static methods and constructors.

Handled SAS connection string in the recorder and added tests and recordings accordingly.

Changes in this PR

@HarshaNalluru HarshaNalluru added Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files) labels Aug 2, 2019
@HarshaNalluru HarshaNalluru self-assigned this Aug 2, 2019
// Skipping for now, further investigation needed on the errors in playback
"browsers/blobclient/recording_startcopyfromclient.json"
"browsers/blobclient/recording_startcopyfromclient.json",
"node/blockblobclient/recording_can_be_created_with_a_sas_connection_string.js"
Copy link
Contributor Author

@HarshaNalluru HarshaNalluru Aug 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In blockblobclient, this specific test can_be_created_with_a_sas_connection_string failed during playback in NodeJS runtime, works fine in the browser.
[ live test succeeds for both node and browser ]

Tried fixing it, but couldn't. More investigation is required - #4633.
Skipping the test for now.

@HarshaNalluru HarshaNalluru merged commit 5fb3978 into Azure:feature/storage Aug 2, 2019
@sarink
Copy link

sarink commented Aug 28, 2019

Is there any example on how to use this?

@HarshaNalluru
Copy link
Contributor Author

Is there any example on how to use this?

I've added this comment to your issue #4923, @sarink.

The storage-blob version 10 API that you've been using doesn't provide the support for passing the connection string directly.

The new support for the SAS connection string has been added in the version 12.0.0-preview.2 - Link.

npm link for 12.0.0-preview.2 version - https://www.npmjs.com/package/@azure/storage-blob/v/12.0.0-preview.2

Here's the sample that shows the usage - withConnString.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants