Remove unused dependencies from testhub#4616
Merged
mikeharder merged 2 commits intoAzure:masterfrom Aug 2, 2019
Merged
Conversation
mikeharder
requested review from
ShivangiReja,
chradek and
ramya-rao-a
as code owners
ramya-rao-a
suggested changes
Aug 1, 2019
Contributor
ramya-rao-a
left a comment
ramya-rao-a
left a comment
There was a problem hiding this comment.
ms-rest-azure is not used by testhub at all. I did a round of checks, and we can remove the below dependencies for testhub
- ms-rest
- ms-rest-azure
- jssha
- is-buffer
mikeharder
force-pushed
the
update-ms-rest-azure
branch
from
69a54e1 to
0c51689
Compare
mikeharder
changed the title
Member
Author
|
@ramya-rao-a: Thanks for the suggestion, I have removed all the packages you listed. |
ramya-rao-a
approved these changes
Aug 2, 2019
Contributor
ramya-rao-a
left a comment
ramya-rao-a
left a comment
There was a problem hiding this comment.
Isnt deleting things fun? :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.