Skip to content

generate signalr mgmt plane package #4606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaeljqzq merged 5 commits into from
Aug 1, 2019
Merged

generate signalr mgmt plane package #4606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a694fe9
generate signalr mgmt plane package
michaeljqzq Aug 1, 2019
b922f65
Bump patch version
michaeljqzq Aug 1, 2019
aa9db6b
Revert change for libraries
michaeljqzq Aug 1, 2019
6f2afa4
bump major version due to api-version change
michaeljqzq Aug 1, 2019
5038ac8
Update signalRManagementClientContext.ts
michaeljqzq Aug 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/signalr/arm-signalr/LICENSE.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
The MIT License (MIT)

Copyright (c) 2018 Microsoft
Copyright (c) 2019 Microsoft

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand Down
9 changes: 4 additions & 5 deletions sdk/signalr/arm-signalr/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ This package contains an isomorphic SDK for SignalRManagementClient.

### How to Install

```
```bash
npm install @azure/arm-signalr
```

Expand All @@ -19,13 +19,13 @@ npm install @azure/arm-signalr

##### Install @azure/ms-rest-nodeauth

```
```bash
npm install @azure/ms-rest-nodeauth
```

##### Sample code

```ts
```typescript
import * as msRest from "@azure/ms-rest-js";
import * as msRestAzure from "@azure/ms-rest-azure-js";
import * as msRestNodeAuth from "@azure/ms-rest-nodeauth";
Expand All @@ -47,7 +47,7 @@ msRestNodeAuth.interactiveLogin().then((creds) => {

##### Install @azure/ms-rest-browserauth

```
```bash
npm install @azure/ms-rest-browserauth
```

Expand Down Expand Up @@ -95,5 +95,4 @@ See https://github.com/Azure/ms-rest-browserauth to learn how to authenticate to

- [Microsoft Azure SDK for Javascript](https://github.com/Azure/azure-sdk-for-js)


![Impressions](https://azure-sdk-impressions.azurewebsites.net/api/impressions/azure-sdk-for-js/sdk/signalr/arm-signalr/README.png)
16 changes: 9 additions & 7 deletions sdk/signalr/arm-signalr/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
"name": "@azure/arm-signalr",
"author": "Microsoft Corporation",
"description": "SignalRManagementClient Library with typescript type definitions for node.js and browser.",
"version": "1.2.0",
"version": "2.0.0",
"dependencies": {
"@azure/ms-rest-azure-js": "^1.1.0",
"@azure/ms-rest-js": "^1.1.0",
"@azure/ms-rest-azure-js": "^1.3.2",
"@azure/ms-rest-js": "^1.8.1",
Copy link
Copy Markdown
Contributor

@ramya-rao-a ramya-rao-a Aug 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be using version 2 of ms-rest-js and ms-rest-azure-js libraries.
If we re-generate the code using the right version of the generator like @amarzavery said, the above should get fixed

Copy link
Copy Markdown
Contributor

@amarzavery amarzavery Aug 1, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

autorest --reset
autorest --latest --typescript
autorest --info
AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest


Showing All Installed Extensions

 Type       Extension Name                           Version      Location 
 core       @microsoft.azure/autorest-core           2.0.4390     /Users/amarz/.autorest/@microsoft.azure_autorest-core@2.0.4390
 extension  @microsoft.azure/autorest.modeler        2.3.51       /Users/amarz/.autorest/@microsoft.azure_autorest.modeler@2.3.51
 extension  @microsoft.azure/autorest.typescript     4.2.1        /Users/amarz/.autorest/@microsoft.azure_autorest.typescript@4.2.1


amarz-MBP:sdk amarz$

As you can see it installs 4.2.1 version of TS generator. After doing that, if you do NOT specify the --use="@microsoft.azure/autorest.typescript@4.2.1 switch then it is fine. Since autorest will automatically use the currently installed version of the TS generator

Copy link
Copy Markdown
Contributor

@amarzavery amarzavery Aug 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaeljqzq - An update, please use 4.2.2 version of @microsoft.azure/autorest.typescript to generate the sdk.

"tslib": "^1.9.3"
},
"keywords": [
Expand All @@ -23,15 +23,16 @@
"typescript": "^3.1.1",
"rollup": "^0.66.2",
"rollup-plugin-node-resolve": "^3.4.0",
"rollup-plugin-sourcemaps": "^0.4.2",
"uglify-js": "^3.4.9"
},
"homepage": "https://github.com/azure/azure-sdk-for-js/tree/master/sdk/signalr/arm-signalr",
"homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/signalr/arm-signalr",
"repository": {
"type": "git",
"url": "https://github.com/azure/azure-sdk-for-js.git"
"url": "https://github.com/Azure/azure-sdk-for-js.git"
},
"bugs": {
"url": "https://github.com/azure/azure-sdk-for-js/issues"
"url": "https://github.com/Azure/azure-sdk-for-js/issues"
},
"files": [
"dist/**/*.js",
Expand All @@ -43,6 +44,7 @@
"esm/**/*.d.ts",
"esm/**/*.d.ts.map",
"src/**/*.ts",
"README.md",
"rollup.config.js",
"tsconfig.json"
],
Expand All @@ -52,5 +54,5 @@
"prepack": "npm install && npm run build"
},
"sideEffects": false,
"authPublish": true
"autoPublish": true
}
22 changes: 14 additions & 8 deletions sdk/signalr/arm-signalr/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,16 @@
import rollup from "rollup";
import nodeResolve from "rollup-plugin-node-resolve";
import sourcemaps from "rollup-plugin-sourcemaps";

/**
* @type {import('rollup').RollupFileOptions}
* @type {rollup.RollupFileOptions}
*/
const config = {
input: './esm/signalRManagementClient.js',
external: ["@azure/ms-rest-js", "@azure/ms-rest-azure-js"],
input: "./esm/signalRManagementClient.js",
external: [
"@azure/ms-rest-js",
"@azure/ms-rest-azure-js"
],
output: {
file: "./dist/arm-signalr.js",
format: "umd",
Expand All @@ -16,16 +22,16 @@ const config = {
},
banner: `/*
* Copyright (c) Microsoft Corporation. All rights reserved.
* Licensed under the MIT License. See License.txt in the project root for
* license information.
* Licensed under the MIT License. See License.txt in the project root for license information.
*
* Code generated by Microsoft (R) AutoRest Code Generator.
* Changes may cause incorrect behavior and will be lost if the code is
* regenerated.
* Changes may cause incorrect behavior and will be lost if the code is regenerated.
*/`
},
plugins: [
nodeResolve({ module: true })
nodeResolve({ module: true }),
sourcemaps()
]
};

export default config;
Loading