[Storage] Imports @azure/abort-controller - storage-blob#4502
Merged
HarshaNalluru merged 8 commits intoAzure:feature/storagefrom Aug 1, 2019
Merged
[Storage] Imports @azure/abort-controller - storage-blob#4502HarshaNalluru merged 8 commits intoAzure:feature/storagefrom
@azure/abort-controller - storage-blob#4502HarshaNalluru merged 8 commits intoAzure:feature/storagefrom
Conversation
HarshaNalluru
added
Client
ramya-rao-a
reviewed
Jul 30, 2019
| options: AppendBlobCreateOptions = {} | ||
| ): Promise<Models.AppendBlobCreateResponse> { | ||
| const aborter = options.abortSignal || Aborter.none; | ||
| const aborter = options.abortSignal || AbortSignal.none; |
Contributor
There was a problem hiding this comment.
Isn't the abortSignal optional in the options passed to the create method below?
If so, then why do we set it to AbortSignal.none?
Can't the underlying code handle the case of no abort signal?
Contributor
Author
There was a problem hiding this comment.
I think you're right, I'm not sure why Jeremy added it in the first place.
I can remove it and see if that breaks anything.
We might have to do the same at many other places.
Contributor
Author
There was a problem hiding this comment.
Created a new issue #4570 to track and update everywhere we do this in all the storage-packages
XiaoningLiu
requested changes
Jul 31, 2019
Member
XiaoningLiu
left a comment
XiaoningLiu
left a comment
There was a problem hiding this comment.
We can leverage aborter.spec.ts to make sure the new Aborter package works properly with storage SDKs, can you bring it back?
XiaoningLiu
approved these changes
Aug 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update storage-blob to use the @azure/aborter-controller library and remove the existing Aborter from the src folder, updates tests, recordings, changelog accordingly.