[core-auth] Fix 'browser' path configuration in core-auth#4460
Merged
daviwil merged 1 commit intoAzure:masterfrom Jul 26, 2019
Merged
[core-auth] Fix 'browser' path configuration in core-auth#4460daviwil merged 1 commit intoAzure:masterfrom
daviwil merged 1 commit intoAzure:masterfrom
Conversation
mikeharder
approved these changes
Jul 26, 2019
Member
|
I agree that |
Contributor
Author
|
Thanks Mike! I confirmed with @bterlson offline that we should have these paths set correctly even if it seems Rollup doesn't resolve them in our current builds. He suggests that we could add a linting check for it too, possibly as a result of @arpanlaha's work. For now I'll go ahead and merge this and then I can help you with the testing story for #4461. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This corrects the
browserconfiguration incore-auth'spackage.jsonfile to ensure that it points to the correct browser output file. Presumably this would only affect consumers who are trying to directly reference this library in a Rollup build.It actually looks like
sdk/template/templatemay have this configured incorrectly, that's where I copied it from. @bterlson: do you know if this file remapping inbrowseris needed for consumers of our libraries?