Skip to content

[AutoPR @azure/arm-apimanagement] [Hub Generated] Review request for Microsoft.ApiManagement to add version preview/2018-06-01-preview#4431

Merged
openapi-sdkautomation[bot] merged 1 commit intoAzure:sdkAutomation/@azure/arm-apimanagementfrom
AzureSDKAutomation:sdkAutomation/@azure/arm-apimanagement@6726
Jul 29, 2019
Merged

[AutoPR @azure/arm-apimanagement] [Hub Generated] Review request for Microsoft.ApiManagement to add version preview/2018-06-01-preview#4431
openapi-sdkautomation[bot] merged 1 commit intoAzure:sdkAutomation/@azure/arm-apimanagementfrom
AzureSDKAutomation:sdkAutomation/@azure/arm-apimanagement@6726

Conversation

@openapi-sdkautomation
Copy link
Contributor

@openapi-sdkautomation
Copy link
Contributor Author

Installation Instructions

You can install the package @azure/arm-apimanagement of this PR using the following command:

npm install https://openapistorageprod.blob.core.windows.net/sdkautomation/prod/Azure/azure-rest-api-specs/6726/9/Azure/azure-sdk-for-js/@azure/arm-apimanagement/azure-arm-apimanagement-5.1.0.tgz

Direct Download

The generated package can be directly downloaded from here:

@msftclas
Copy link

msftclas commented Jul 25, 2019

CLA assistant check
All CLA requirements met.

@ramya-rao-a
Copy link
Contributor

@daviwil Looks like this got generated using the new code generator which uses the new core libraries which shouldn't be used just yet...

@ramya-rao-a ramya-rao-a requested a review from daviwil July 26, 2019 15:09
Copy link
Contributor

@daviwil daviwil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be regenerated using autorest.typescript 4.1.1.

@openapi-sdkautomation openapi-sdkautomation bot merged commit 99a7adc into Azure:sdkAutomation/@azure/arm-apimanagement Jul 29, 2019
@openapi-sdkautomation openapi-sdkautomation bot deleted the sdkAutomation/@azure/arm-apimanagement@6726 branch July 29, 2019 17:03
@openapi-sdkautomation
Copy link
Contributor Author

Integration Pull Request: #4495

@ramya-rao-a
Copy link
Contributor

This PR is using the new core packages... It shouldn't have been merged before re-generating using the older generator

@daviwil Can we follow up on this?

@daviwil
Copy link
Contributor

daviwil commented Jul 29, 2019

@ramya-rao-a I asked @daschult about these PRs on Friday and he told me that these "Hub Generated" PRs get created automatically when PRs are created on the azure-rest-api-specs repo. When the corresponding spec PR gets merged, this PR automatically gets merged into an integration branch and a new PR gets created against master. This new PR (#4495) is the one we can tweak before merging, so I'll go regenerate the code there to make sure it's using the correct version of the generator.

openapi-sdkautomation bot added a commit that referenced this pull request Jul 30, 2019
openapi-sdkautomation bot added a commit that referenced this pull request Jul 30, 2019
openapi-sdkautomation bot added a commit that referenced this pull request Jul 30, 2019
openapi-sdkautomation bot added a commit that referenced this pull request Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants