[Identity] Add UsernamePasswordCredential for username/password authentication#4404
Merged
daviwil merged 3 commits intoAzure:masterfrom Jul 30, 2019
Merged
[Identity] Add UsernamePasswordCredential for username/password authentication#4404daviwil merged 3 commits intoAzure:masterfrom
daviwil merged 3 commits intoAzure:masterfrom
Conversation
sophiajt
approved these changes
Jul 24, 2019
Contributor
sophiajt
left a comment
sophiajt
left a comment
There was a problem hiding this comment.
Looks good (assuming we always force them to connect via https). I'm guessing Scott should also take a look.
Contributor
Author
|
I don't force it right now, but I probably should. So long as it doesn't negatively impact test scenarios it'll be easy to throw when |
daviwil
force-pushed
the
user-pass-credential
branch
from
39049d0 to
b6c7194
Compare
Contributor
Author
|
Added the |
schaabs
reviewed
Jul 29, 2019
|
|
||
| if (!this.baseUri.startsWith("https:")) { | ||
| throw new Error("The authorityHost address must use the 'https' protocol."); | ||
| } |
There was a problem hiding this comment.
This check might be too restrictive if this client supports ADFS
Contributor
Author
There was a problem hiding this comment.
Should I check for it at all, or leave it for now and see if anyone runs into trouble with it?
schaabs
approved these changes
Jul 29, 2019
Contributor
Author
|
I'll go ahead and merge this and then will update the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds username/password authentication as described in the AAD OAuth documentation:
https://docs.microsoft.com/en-us/azure/active-directory/develop/v2-oauth-ropc
Resolves #4310.