[core-amqp] Refactor time units to milliseconds

[ramya0820]

• Using suffix 'InMs' as discussed earlier @bterlson @ramya-rao-a
• Due to use of seconds in rhea-promise, some multiply/divide 1000 conversions are inevitable
• this PR is for core-amqp package only, once this PR is final and other Event Hub PRs in flight are through, can send another / update same PR to consume these changes from Event Hubs

For more context refer to #4277

cc: @ramya-rao-a

[ShivangiReja]

Build is failing because Event Hubs needs to be updated.

[chradek]

Seconding what @ShivangiReja said.

[ramya0820]

Seconding what @ShivangiReja said.

Please see the PR description - "this PR is for core-amqp package only, once this PR is final and other Event Hub PRs in flight are through, can send another / update same PR to consume these changes from Event Hubs"

This one's for core-amqp only and with what we have on master branch.
Waiting on other PRs as part of #2835 to be merged, before Event Hubs related changes are updated.

[chradek]

But we can't merge this if it fails master right? We should never allow master to get into a state where it fails to build.

[ramya0820]

But we can't merge this if it fails master right? We should never allow master to get into a state where it fails to build.

Yes, GitHub will not allow PRs to be merged unless the conflicts and syntax/build errors are fixed. So it is automatically not allowed and we don't have to worry about these going into master.

[chradek]

Ah, well then for what it's worth I think these changes look fine, I would wait to approve until the build is passing though.

[ramya0820]

cc: @ramya-rao-a @chradek

Merged in changes from #4400 and updated EventHubs to absorb the seconds -> milliseconds refactor in core-amqp

Also, it looks like there might be a bug with usage of await delay(..) within retry.
Investigated and needed to update "should surface error through retry" test with different delay values. May need to file an issue for this to look into it further.

[ramya-rao-a]

This doesnt need any checks anymore. We should be able to say delayInMs: retryOptions.retryInterval and expect core-amqp to do all the checks

[ramya-rao-a]

Same for other places that have this pattern