Add princiaplType to arm-authorization.#4331
Closed
ahmagdy wants to merge 2 commits intoAzure:masterfrom
Closed
Conversation
Map PrincipalType and make it included in the parsed response.
Author
|
@mikeharder @daviwil @chradek @ramya-rao-a @sadasant |
Contributor
|
@rthorn17 - is this something you can help with? |
Contributor
|
The code here is mainly auto-generated code, so I don't believe we can accept manual changes in PRs. |
ramya-rao-a
added
Authorization
Mgmt
Contributor
|
@daviwil From your recent code-gen experience, would you say that this change needs to happen in the swagger spec first and then the code re-generated? |
Contributor
|
May be we just need to regenerate with latest swagger spec for authorization |
Merged
Contributor
|
@ahmad-magdy A new version of @azure/arm-authorization (8.3.2) has been released which has the changes to include principalType. So, I am closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include princiaplType in the parsed response and add it the model.
In my case, I tried to use AuthorizationManagmentClient to get the role assignments for a resource group,
authorizationManagmentClient.listForResourceGroup('NAME').The response will include principal id and principal type, the SDK will only show the principal id.
It's helpful to parse the type and include it because it will help to get more information about the principal id.
So this PR is extending this part.