Sync eng/common directory with azure-sdk-tools for PR 16674

[azure-sdk-automation]

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#16674 See eng/common workflow

[azure-pipelines]

Azure Pipelines:
Successfully started running 1 pipeline(s).
10 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[Copilot]

Pull request overview

Note

Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.

Adds support for pool-specific PR matrix job batching so different agent pools can process different numbers of PackageInfo entries per PR job.

Changes:

• Introduces a new template parameter PRJobBatchSizeByPool for per-pool batch size overrides.
• Adds PowerShell logic to resolve the effective batch size (default vs. override) and validate it.
• Updates the PR matrix generation invocation to pass the resolved $batchSize instead of the global default.

---

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

[Wei Lim (weikanglim)]

The synchronized eng/common change is ready. Required checks are passing and all review threads have been addressed.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (2)

eng/common/pipelines/templates/jobs/generate-job-matrix.yml:153

• Embedding JSON into a single-quoted PowerShell string can break if the JSON contains a single quote character (e.g., a pool name or value containing '), causing ConvertFrom-Json to fail. To make this robust, write the JSON to a file (similar to matrix.json) and read/parse it, or use a PowerShell here-string that safely contains the JSON payload.

            $batchSize = ${{ parameters.PRJobBatchSize }}
            $overrides = '${{ convertToJson(parameters.PRJobBatchSizeByPool) }}' | ConvertFrom-Json

eng/common/pipelines/templates/jobs/generate-job-matrix.yml:156

• This property lookup is more complex than necessary and harder to read/maintain (pipeline + filtering) for a simple key lookup. Consider using a direct lookup approach (e.g., retrieving the property by name from PSObject.Properties or indexing into a hashtable) to reduce indirection and make the intent clearer.

            $poolOverride = $overrides.PSObject.Properties |
              Where-Object { $_.Name -eq '${{ pool.name }}' } |
              Select-Object -First 1

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (2)

eng/common/pipelines/templates/jobs/generate-job-matrix.yml:152

• PRJobBatchSizeis declared as a YAMLnumber, which can include non-integer values (e.g. 2.5). The current logic only validates > 0and passes$batchSizethrough to-PackagesPerPRJob`, which is conceptually an integer count. Please enforce that the default value is an integer as well (e.g., by validating it’s a whole number and throwing a clear error if not), not only the override path. This prevents accidental fractional values from causing incorrect batching or downstream script errors.

            $batchSize = ${{ parameters.PRJobBatchSize }}

eng/common/pipelines/templates/jobs/generate-job-matrix.yml:172

• PRJobBatchSizeis declared as a YAMLnumber, which can include non-integer values (e.g. 2.5). The current logic only validates > 0and passes$batchSizethrough to-PackagesPerPRJob`, which is conceptually an integer count. Please enforce that the default value is an integer as well (e.g., by validating it’s a whole number and throwing a clear error if not), not only the override path. This prevents accidental fractional values from causing incorrect batching or downstream script errors.

            if ($batchSize -le 0) {
              throw "PR job batch size for ${{ pool.name }} must be greater than zero."
            }