fix(core-client): fix typos in serializer error messages#38258
Merged
deyaaeldeen merged 1 commit intomainfrom Apr 23, 2026
Merged
fix(core-client): fix typos in serializer error messages#38258deyaaeldeen merged 1 commit intomainfrom
deyaaeldeen merged 1 commit intomainfrom
Conversation
Fix two issues in the "element metadata" error messages: - Add missing opening quote: `element"` → `"element"` - Fix grammar: "it must of type" → "it must be of type" Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates array element metadata error messages in core-client serialization/deserialization to fix quoting and grammar, and aligns the corresponding test expectations.
Changes:
- Fixed missing opening quote around
"element"in array metadata error messages. - Corrected grammar from “must of type” to “must be of type” in both serialize/deserialize paths.
- Updated serializer tests’ regex matchers to the new wording.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk/core/core-client/src/serializer.ts | Fixes the two error message typos in both serialize and deserialize sequence type handling. |
| sdk/core/core-client/test/public/serializer.spec.ts | Updates regex expectations to match the corrected error message text. |
jeremymeng
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix two issues in the Array element metadata error messages in
serializer.ts:element"→"element"Both occurrences (serialize and deserialize paths) are fixed. Test regexes updated to match.
Fixes feedback from #38176.