Improve test coverage to ~100% for @azure/core-lro#38178

Merged

deyaaeldeen merged 37 commits intomainfrom

deyaaeldeen/core-lro-test-coverage

Apr 21, 2026

Commits on Apr 16, 2026

Improve test coverage to ~100% for @azure/core-lro

Deyaaeldeen Almahallawi
and
Copilot
committed

Commits on Apr 17, 2026

Remove 'coverage' from test describe block names

Deyaaeldeen Almahallawi
and
Copilot
committed
Remove 'edge cases' from describe block names

Deyaaeldeen Almahallawi
and
Copilot
committed
Strengthen isDefined-only assertions with value checks

Deyaaeldeen Almahallawi
and
Copilot
committed
Move imports to top level (vitest hoists vi.mock automatically)

Deyaaeldeen Almahallawi
and
Copilot
committed
Fix TypeScript compilation errors caught by CI

Deyaaeldeen Almahallawi
and
Copilot
committed
Move public-API poller tests from internal to public

Deyaaeldeen Almahallawi
and
Copilot
committed
Extract makeRawResponse and makeState to shared test utils

Deyaaeldeen Almahallawi
and
Copilot
committed
Move createTestPoller tests from internal to public (core-lro)

Deyaaeldeen Almahallawi
and
Copilot
committed
Clean up imports: combine duplicates, prefer src/index.js (core-lro)

Deyaaeldeen Almahallawi
and
Copilot
committed
Rename internal test files for clarity (core-lro)

Deyaaeldeen Almahallawi
and
Copilot
committed
Remove old test files after rename

Deyaaeldeen Almahallawi
and
Copilot
committed
Remove unnecessary comments from test files (core-lro)

Deyaaeldeen Almahallawi
and
Copilot
committed
Merge poller.spec.ts into lro.spec.ts (core-lro)

Deyaaeldeen Almahallawi
and
Copilot
committed
Delete poller.spec.ts (merged into lro.spec.ts)

Deyaaeldeen Almahallawi
and
Copilot
committed
Address PR review feedback: fix test names and retry-after value

Deyaaeldeen Almahallawi
and
Copilot
committed
test(core-client-rest): remove redundant strictEqual assertions in clientHelpers tests

Deyaaeldeen Almahallawi
and
Copilot
committed
Fix test substance issues in core-client

Deyaaeldeen Almahallawi
and
Copilot
committed
fix(core-lro): strengthen test assertions for polling interval, custom status, and retry-after

Deyaaeldeen Almahallawi
and
Copilot
committed

Commits on Apr 18, 2026

Merge remote-tracking branch 'origin/main' into deyaaeldeen/core-lro-test-coverage
Deyaaeldeen Almahallawi
committed
fix: merge main and remove dead getCachedDefaultHttpsClient test

Deyaaeldeen Almahallawi
and
Copilot
committed
fix: address audit issues in core-lro tests

Deyaaeldeen Almahallawi
and
Copilot
committed
fix: use isAtLeast in tokenCycler test

Deyaaeldeen Almahallawi
and
Copilot
committed
fix: use assert.strictEqual instead of assert.isTrue(x === y) in lro tests

Deyaaeldeen Almahallawi
and
Copilot
committed
fix: strengthen isDefined to assert actual value in lro state tests

Deyaaeldeen Almahallawi
and
Copilot
committed

Commits on Apr 19, 2026

refactor: replace non-null assertions with optional chaining in lro tests

Deyaaeldeen Almahallawi
and
Copilot
committed
refactor: modernize spy patterns in core-lro tests

Deyaaeldeen Almahallawi
and
Copilot
committed
refactor: second pass modernization in core-lro tests

Deyaaeldeen Almahallawi
and
Copilot
committed
fix: resolve TS2339 on operationState?.status in lro tests

Deyaaeldeen Almahallawi
and
Copilot
committed
refactor: third pass modernization in core-lro tests

Deyaaeldeen Almahallawi
and
Copilot
committed
fix: remove foreign package files from core-lro branch

Deyaaeldeen Almahallawi
and
Copilot
committed

Commits on Apr 20, 2026

Eliminate unnecessary type casts in core-lro tests

Deyaaeldeen Almahallawi
and
Copilot
committed

Commits on Apr 21, 2026

fix: align test title with actual assertion in http-operation.spec.ts

Deyaaeldeen Almahallawi
and
Copilot
committed
Address PR feedback: fix test titles, strengthen assertions, add missing test

Deyaaeldeen Almahallawi
and
Copilot
committed
Remove stale temp file

Deyaaeldeen Almahallawi
and
Copilot
committed
Add idempotency comment on duplicate poll assertion

Deyaaeldeen Almahallawi
and
Copilot
committed
Add idempotency comment on canceled poll assertion

Deyaaeldeen Almahallawi
and
Copilot
committed