chore(core): remove dead code, unnecessary casts, and redundant async

[deyaaeldeen]

Summary

Remove dead code, unnecessary type casts, and redundant async keywords across core packages.

Dead code removal

• AsyncLockOptions interface, Timeout class (core-amqp)
• isBearerToken, isPopToken helpers (core-auth)
• getCachedDefaultHttpsClient, unused HttpClient import (core-client-rest)
• Stale declare global { interface Event {} } (abort-controller)

Cast removal / type narrowing

• as any → as ParsedOutput in parseConnectionString (core-amqp)
• { [k: string]: string } → Record (core-amqp)
• as string → ?? "" for CAE challenge header (core-rest-pipeline)
• isKeyCredential param any → unknown with proper guard (core-client-rest)
• objectHasProperty tightened with null check (core-util)

Redundant async removal

• sendRequest, sendPolicy handlers that just return a promise without awaiting (core-client, core-client-rest, core-http-compat, core-lro)

Simplify defensive logic

• ndJsonPolicy: Remove unreachable Array.isArray guard after JSON.parse on a string starting with [ (JSON spec guarantees array result)
• tokenCycler: Replace optional chaining with explicit null guard in shouldRefresh, making intent clearer

Other improvements

• Resolved simplified to Awaited with deprecation notice (core-tracing)
• HttpHeaders class made non-exported (core-http-compat, was already not in public API)
• Set for passthrough props lookup (core-http-compat)
• XML root key extraction simplified (core-xml)
• URL scope construction fix (core-client)
• Optional chaining removed on guaranteed field (core-paging)

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Removes dead code, redundant async usage, and unnecessary casts/type aliases across core packages, aiming to simplify implementations and tighten typing.

Changes:

• Removed unused helpers/types and stale declarations across multiple core packages.
• Simplified type handling (e.g., Resolved<T> → Awaited<T>, narrower type guards, fewer casts).
• Removed redundant async wrappers that only forwarded promises and made small micro-optimizations (e.g., Set membership).

Reviewed changes

Copilot reviewed 22 out of 23 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
sdk/core/core-xml/src/xml.ts	Simplifies root key extraction when includeRoot is false.
sdk/core/core-util/src/typeGuards.ts	Tightens objectHasProperty implementation with explicit null check.
sdk/core/core-tracing/src/tracingClient.ts	Replaces Resolved with Awaited, removes redundant Promise.resolve, and simplifies object literals.
sdk/core/core-tracing/src/interfaces.ts	Deprecates Resolved in favor of built-in Awaited.
sdk/core/core-tracing/review/core-tracing-node.api.md	Updates public API surface to mark Resolved deprecated and uses Awaited.
sdk/core/core-rest-pipeline/src/policies/bearerTokenAuthenticationPolicy.ts	Removes unsafe cast on WWW-Authenticate header retrieval.
sdk/core/core-paging/src/getPagedAsyncIterator.ts	Removes optional chaining on a guaranteed pagedResult reference.
sdk/core/core-lro/src/poller/poller.ts	Removes redundant async from progress event handler.
sdk/core/core-lro/src/http/operation.ts	Removes redundant async wrapper around lro.sendPollRequest.
sdk/core/core-http-compat/src/util.ts	Replaces passthrough prop list with a Set; makes HttpHeaders non-exported.
sdk/core/core-http-compat/src/policies/disableKeepAlivePolicy.ts	Removes redundant async from policy sendRequest.
sdk/core/core-client/src/urlHelpers.ts	Refactors URL path/search scope construction.
sdk/core/core-client/src/serviceClient.ts	Removes redundant async in sendRequest; adjusts credential scope error condition.
sdk/core/core-client/src/serializationPolicy.ts	Removes redundant async from policy sendRequest.
sdk/core/core-client/src/authorizeRequestOnTenantChallenge.ts	Fixes scope URL construction using URL base resolution.
sdk/core/core-client-rest/src/restError.ts	Replaces non-null assertion with safer cast for forwarding to tsp helper.
sdk/core/core-client-rest/src/keyCredentialAuthenticationPolicy.ts	Removes redundant async from policy sendRequest.
sdk/core/core-client-rest/src/clientHelpers.ts	Removes cached HTTP client dead code; tightens isKeyCredential parameter type.
sdk/core/core-client-rest/src/apiVersionPolicy.ts	Simplifies query param presence check using searchParams.size.
sdk/core/core-auth/src/tokenCredential.ts	Removes unused internal token-type helper functions.
sdk/core/core-amqp/src/util/utils.ts	Removes dead types/helpers; tightens parseConnectionString return typing.
sdk/core/abort-controller/src/index.ts	Removes stale global Event declaration.

Files not reviewed (1)

• pnpm-lock.yaml: Language not supported

[Copilot]

Pull request overview

Copilot reviewed 27 out of 27 changed files in this pull request and generated 5 comments.

[xirzec]

Mostly good, though I have some questions.

[xirzec]

Pretty sure the tokenCycler change is incorrect