fix: add safe-output targets for pull_request_target context#37832
Merged
deyaaeldeen merged 1 commit intomainfrom Mar 25, 2026
Merged
fix: add safe-output targets for pull_request_target context#37832deyaaeldeen merged 1 commit intomainfrom
deyaaeldeen merged 1 commit intomainfrom
Conversation
With pull_request_target, the safe output handler can't auto-detect the PR context. Add explicit target fields to create-pull-request-review-comment and submit-pull-request-review (matching mgmt-review pattern). Also upgrades compiled lock files from gh-aw v0.56.2 to v0.63.1. Failing run: https://github.com/Azure/azure-sdk-for-js/actions/runs/23555872650 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub review-agent workflows to correctly emit “safe outputs” review comments when running under the pull_request_target event by explicitly setting the PR “target” number, and also refreshes the generated .lock.yml workflows to a newer gh-aw compiler/runtime version.
Changes:
- Add explicit
safe-outputs.*.targetexpressions to 6 review-agent workflow source files (*.md) so PR context is unambiguous underpull_request_target. - Re-compile corresponding workflow lock files with
gh-awv0.63.1 (schema v3), updating action versions, paths, and safe-outputs tool generation.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/tester.md | Adds target to safe-output review comment + review submission handlers. |
| .github/workflows/tester.lock.yml | Recompiled workflow (gh-aw v0.63.1) + embeds target into safe-outputs config. |
| .github/workflows/sentinel.md | Adds target to safe-output review comment + review submission handlers. |
| .github/workflows/scribe.md | Adds target to safe-output review comment + review submission handlers. |
| .github/workflows/scribe.lock.yml | Recompiled workflow (gh-aw v0.63.1) + embeds target into safe-outputs config. |
| .github/workflows/dexter.md | Adds target to safe-output review comment + review submission handlers. |
| .github/workflows/dash.md | Adds target to safe-output review comment + review submission handlers. |
| .github/workflows/dash.lock.yml | Recompiled workflow (gh-aw v0.63.1) + embeds target into safe-outputs config. |
| .github/workflows/archie.md | Adds target to safe-output review comment + review submission handlers. |
| .github/workflows/archie.lock.yml | Recompiled workflow (gh-aw v0.63.1) + embeds target into safe-outputs config. |
jeremymeng
approved these changes
Mar 25, 2026
Member
Author
|
Filed github/gh-aw#22957 for copilot feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
pull_request_target, the safe output handler can't auto-detect the PR context, causing all review comments to fail with:This adds explicit
targetfields tocreate-pull-request-review-commentandsubmit-pull-request-reviewin all 6 review agent workflows, matching the pattern already used by mgmt-review.Also upgrades compiled lock files from gh-aw v0.56.2 to v0.63.1.
Failing run: https://github.com/Azure/azure-sdk-for-js/actions/runs/23555872650