Skip to content

[AutoPR @azure-arm-appnetwork]-generated-from-SDK Generation - JS-6060206#37826

Merged
deveshdama merged 1 commit intomainfrom
sdkauto/@azure-arm-appnetwork-6060206
Mar 26, 2026
Merged

[AutoPR @azure-arm-appnetwork]-generated-from-SDK Generation - JS-6060206#37826
deveshdama merged 1 commit intomainfrom
sdkauto/@azure-arm-appnetwork-6060206

Conversation

@azure-sdk
Copy link
Copy Markdown
Collaborator

@azure-sdk azure-sdk commented Mar 25, 2026

Configurations: 'specification/applink/AppLink.Management/tspconfig.yaml', API Version: 2025-08-01-preview, SDK Release Type: beta, and CommitSHA: 'bf394b468f3f3cf9d0c678282d7efdf9b3411132' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6060206 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=0aeba4af-c706-f111-8406-000d3a5b007c Submitted by: ddama@microsoft.com

Release Plan Details

@github-actions github-actions Bot added the Mgmt This issue is related to a management-plane library. label Mar 25, 2026
@github-actions
Copy link
Copy Markdown
Contributor

API Change Check

APIView identified API level changes in this PR and created the following API reviews

@azure/arm-appnetwork

@deveshdama deveshdama marked this pull request as ready for review March 25, 2026 07:45
Copilot AI review requested due to automatic review settings March 25, 2026 07:45
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a new auto-generated Azure Resource Manager (management-plane) JavaScript/TypeScript SDK package for AppLink (@azure/arm-appnetwork) based on 2025-08-01-preview, along with CI wiring, API review artifacts, samples, and test scaffolding.

Changes:

  • Added the new sdk/appnetwork/arm-appnetwork package (client, operations, models, helpers) and its build/test/config files.
  • Added samples (JS/TS) and API Extractor review reports for the new package.
  • Wired up CI configurations and repo metadata (CODEOWNERS, link ignore list).

Reviewed changes

Copilot reviewed 116 out of 117 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
sdk/appnetwork/ci.mgmt.yml Adds CI pipeline definition for the new management package.
sdk/appnetwork/arm-appnetwork/warp.config.yml Defines build/export targets and entrypoints for packaging.
sdk/appnetwork/arm-appnetwork/vitest.esm.config.ts Adds Vitest config for ESM test runs.
sdk/appnetwork/arm-appnetwork/vitest.config.ts Adds shared Vitest configuration re-export.
sdk/appnetwork/arm-appnetwork/vitest.browser.config.ts Adds Vitest config for browser test runs.
sdk/appnetwork/arm-appnetwork/tsp-location.yaml Records spec repo location/commit for the generated package.
sdk/appnetwork/arm-appnetwork/tsconfig.test.node.json TS config for Node test compilation/path mapping.
sdk/appnetwork/arm-appnetwork/tsconfig.test.json TS project references for tests.
sdk/appnetwork/arm-appnetwork/tsconfig.src.json TS config for library source compilation.
sdk/appnetwork/arm-appnetwork/tsconfig.snippets.json TS config for snippet compilation.
sdk/appnetwork/arm-appnetwork/tsconfig.samples.json TS config for samples build.
sdk/appnetwork/arm-appnetwork/tsconfig.json TS solution references for the package.
sdk/appnetwork/arm-appnetwork/tsconfig.browser.config.json TS config for browser build/type paths.
sdk/appnetwork/arm-appnetwork/test/snippets.spec.ts Adds snippet tests to validate README snippets compile/run.
sdk/appnetwork/arm-appnetwork/test/public/utils/recordedClient.ts Adds test-recorder helper for recorded tests.
sdk/appnetwork/arm-appnetwork/test/public/sampleTest.spec.ts Adds a placeholder public test file for the package.
sdk/appnetwork/arm-appnetwork/src/static-helpers/urlTemplate.ts Adds RFC6570 URL template expansion helper.
sdk/appnetwork/arm-appnetwork/src/static-helpers/pollingHelpers.ts Adds LRO poller helper for ARM long-running operations.
sdk/appnetwork/arm-appnetwork/src/static-helpers/pagingHelpers.ts Adds paging helper and PagedAsyncIterableIterator implementation.
sdk/appnetwork/arm-appnetwork/src/static-helpers/cloudSettingHelpers.ts Adds cloud setting enum + ARM endpoint resolver.
sdk/appnetwork/arm-appnetwork/src/restorePollerHelpers.ts Adds poller restore helper mapping operations to deserializers.
sdk/appnetwork/arm-appnetwork/src/models/models.ts Adds generated models + serializers/deserializers.
sdk/appnetwork/arm-appnetwork/src/models/index.ts Re-exports public model types and Known* enums.
sdk/appnetwork/arm-appnetwork/src/logger.ts Adds package logger initialization.
sdk/appnetwork/arm-appnetwork/src/index.ts Adds main public exports surface for the package.
sdk/appnetwork/arm-appnetwork/src/classic/upgradeHistories/index.ts Adds classic operation group wrapper for upgradeHistories.
sdk/appnetwork/arm-appnetwork/src/classic/operations/index.ts Adds classic operation group wrapper for operations.
sdk/appnetwork/arm-appnetwork/src/classic/index.ts Aggregates classic operation group type exports.
sdk/appnetwork/arm-appnetwork/src/classic/availableVersions/index.ts Adds classic operation group wrapper for availableVersions.
sdk/appnetwork/arm-appnetwork/src/classic/appLinks/index.ts Adds classic operation group wrapper for appLinks.
sdk/appnetwork/arm-appnetwork/src/classic/appLinkMembers/index.ts Adds classic operation group wrapper for appLinkMembers.
sdk/appnetwork/arm-appnetwork/src/appLinkClient.ts Adds the top-level AppLinkClient wrapper and operation groups.
sdk/appnetwork/arm-appnetwork/src/api/upgradeHistories/options.ts Adds options types for upgradeHistories operations.
sdk/appnetwork/arm-appnetwork/src/api/upgradeHistories/operations.ts Adds generated REST calls + paging for upgradeHistories.
sdk/appnetwork/arm-appnetwork/src/api/upgradeHistories/index.ts Exports upgradeHistories API surface.
sdk/appnetwork/arm-appnetwork/src/api/operations/options.ts Adds options types for operations list.
sdk/appnetwork/arm-appnetwork/src/api/operations/operations.ts Adds generated REST call + paging for provider operations.
sdk/appnetwork/arm-appnetwork/src/api/operations/index.ts Exports operations API surface.
sdk/appnetwork/arm-appnetwork/src/api/index.ts Aggregates API context exports.
sdk/appnetwork/arm-appnetwork/src/api/availableVersions/options.ts Adds options types for availableVersions list (filter).
sdk/appnetwork/arm-appnetwork/src/api/availableVersions/operations.ts Adds generated REST call + paging for availableVersions.
sdk/appnetwork/arm-appnetwork/src/api/availableVersions/index.ts Exports availableVersions API surface.
sdk/appnetwork/arm-appnetwork/src/api/appLinks/options.ts Adds options types for appLinks operations including LRO polling interval.
sdk/appnetwork/arm-appnetwork/src/api/appLinks/operations.ts Adds generated REST calls + paging + LRO for appLinks.
sdk/appnetwork/arm-appnetwork/src/api/appLinks/index.ts Exports appLinks API surface.
sdk/appnetwork/arm-appnetwork/src/api/appLinkMembers/options.ts Adds options types for appLinkMembers operations including LRO polling interval.
sdk/appnetwork/arm-appnetwork/src/api/appLinkMembers/operations.ts Adds generated REST calls + paging + LRO for appLinkMembers.
sdk/appnetwork/arm-appnetwork/src/api/appLinkMembers/index.ts Exports appLinkMembers API surface.
sdk/appnetwork/arm-appnetwork/src/api/appLinkContext.ts Adds REST client context creation (endpoint, scopes, UA, logging).
sdk/appnetwork/arm-appnetwork/samples/v1-beta/typescript/tsconfig.json Adds TS sample project config.
sdk/appnetwork/arm-appnetwork/samples/v1-beta/typescript/src/upgradeHistoriesListByAppLinkMemberSample.ts Adds TS sample for upgradeHistories listing.
sdk/appnetwork/arm-appnetwork/samples/v1-beta/typescript/src/operationsListSample.ts Adds TS sample for provider operations listing.
sdk/appnetwork/arm-appnetwork/samples/v1-beta/typescript/src/availableVersionsListByLocationSample.ts Adds TS samples for availableVersions listing (with/without filter).
sdk/appnetwork/arm-appnetwork/samples/v1-beta/typescript/src/appLinksUpdateSample.ts Adds TS sample for appLinks update (LRO).
sdk/appnetwork/arm-appnetwork/samples/v1-beta/typescript/src/appLinksListBySubscriptionSample.ts Adds TS sample for appLinks list by subscription.
sdk/appnetwork/arm-appnetwork/samples/v1-beta/typescript/src/appLinksListByResourceGroupSample.ts Adds TS sample for appLinks list by resource group.
sdk/appnetwork/arm-appnetwork/samples/v1-beta/typescript/src/appLinksGetSample.ts Adds TS sample for appLinks get.
sdk/appnetwork/arm-appnetwork/samples/v1-beta/typescript/src/appLinksDeleteSample.ts Adds TS sample for appLinks delete (LRO).
sdk/appnetwork/arm-appnetwork/samples/v1-beta/typescript/src/appLinksCreateOrUpdateSample.ts Adds TS sample for appLinks createOrUpdate (LRO).
sdk/appnetwork/arm-appnetwork/samples/v1-beta/typescript/src/appLinkMembersUpdateSample.ts Adds TS sample for appLinkMembers update (LRO).
sdk/appnetwork/arm-appnetwork/samples/v1-beta/typescript/src/appLinkMembersListByAppLinkSample.ts Adds TS sample for appLinkMembers list.
sdk/appnetwork/arm-appnetwork/samples/v1-beta/typescript/src/appLinkMembersGetSample.ts Adds TS sample for appLinkMembers get.
sdk/appnetwork/arm-appnetwork/samples/v1-beta/typescript/src/appLinkMembersDeleteSample.ts Adds TS sample for appLinkMembers delete (LRO).
sdk/appnetwork/arm-appnetwork/samples/v1-beta/typescript/src/appLinkMembersCreateOrUpdateSample.ts Adds TS sample for appLinkMembers createOrUpdate (LRO).
sdk/appnetwork/arm-appnetwork/samples/v1-beta/typescript/sample.env Adds sample env placeholder for TS samples.
sdk/appnetwork/arm-appnetwork/samples/v1-beta/typescript/package.json Adds TS samples package manifest.
sdk/appnetwork/arm-appnetwork/samples/v1-beta/typescript/README.md Adds TS samples README.
sdk/appnetwork/arm-appnetwork/samples/v1-beta/javascript/upgradeHistoriesListByAppLinkMemberSample.js Adds JS sample for upgradeHistories listing.
sdk/appnetwork/arm-appnetwork/samples/v1-beta/javascript/sample.env Adds sample env placeholder for JS samples.
sdk/appnetwork/arm-appnetwork/samples/v1-beta/javascript/package.json Adds JS samples package manifest.
sdk/appnetwork/arm-appnetwork/samples/v1-beta/javascript/operationsListSample.js Adds JS sample for provider operations listing.
sdk/appnetwork/arm-appnetwork/samples/v1-beta/javascript/availableVersionsListByLocationSample.js Adds JS samples for availableVersions listing (with/without filter).
sdk/appnetwork/arm-appnetwork/samples/v1-beta/javascript/appLinksUpdateSample.js Adds JS sample for appLinks update (LRO).
sdk/appnetwork/arm-appnetwork/samples/v1-beta/javascript/appLinksListBySubscriptionSample.js Adds JS sample for appLinks list by subscription.
sdk/appnetwork/arm-appnetwork/samples/v1-beta/javascript/appLinksListByResourceGroupSample.js Adds JS sample for appLinks list by resource group.
sdk/appnetwork/arm-appnetwork/samples/v1-beta/javascript/appLinksGetSample.js Adds JS sample for appLinks get.
sdk/appnetwork/arm-appnetwork/samples/v1-beta/javascript/appLinksDeleteSample.js Adds JS sample for appLinks delete (LRO).
sdk/appnetwork/arm-appnetwork/samples/v1-beta/javascript/appLinksCreateOrUpdateSample.js Adds JS sample for appLinks createOrUpdate (LRO).
sdk/appnetwork/arm-appnetwork/samples/v1-beta/javascript/appLinkMembersUpdateSample.js Adds JS sample for appLinkMembers update (LRO).
sdk/appnetwork/arm-appnetwork/samples/v1-beta/javascript/appLinkMembersListByAppLinkSample.js Adds JS sample for appLinkMembers list.
sdk/appnetwork/arm-appnetwork/samples/v1-beta/javascript/appLinkMembersGetSample.js Adds JS sample for appLinkMembers get.
sdk/appnetwork/arm-appnetwork/samples/v1-beta/javascript/appLinkMembersDeleteSample.js Adds JS sample for appLinkMembers delete (LRO).
sdk/appnetwork/arm-appnetwork/samples/v1-beta/javascript/appLinkMembersCreateOrUpdateSample.js Adds JS sample for appLinkMembers createOrUpdate (LRO).
sdk/appnetwork/arm-appnetwork/samples/v1-beta/javascript/README.md Adds JS samples README.
sdk/appnetwork/arm-appnetwork/samples-dev/upgradeHistoriesListByAppLinkMemberSample.ts Adds dev sample for upgradeHistories listing.
sdk/appnetwork/arm-appnetwork/samples-dev/operationsListSample.ts Adds dev sample for provider operations listing.
sdk/appnetwork/arm-appnetwork/samples-dev/availableVersionsListByLocationSample.ts Adds dev samples for availableVersions listing (with/without filter).
sdk/appnetwork/arm-appnetwork/samples-dev/appLinksUpdateSample.ts Adds dev sample for appLinks update (LRO).
sdk/appnetwork/arm-appnetwork/samples-dev/appLinksListBySubscriptionSample.ts Adds dev sample for appLinks list by subscription.
sdk/appnetwork/arm-appnetwork/samples-dev/appLinksListByResourceGroupSample.ts Adds dev sample for appLinks list by resource group.
sdk/appnetwork/arm-appnetwork/samples-dev/appLinksGetSample.ts Adds dev sample for appLinks get.
sdk/appnetwork/arm-appnetwork/samples-dev/appLinksDeleteSample.ts Adds dev sample for appLinks delete (LRO).
sdk/appnetwork/arm-appnetwork/samples-dev/appLinksCreateOrUpdateSample.ts Adds dev sample for appLinks createOrUpdate (LRO).
sdk/appnetwork/arm-appnetwork/samples-dev/appLinkMembersUpdateSample.ts Adds dev sample for appLinkMembers update (LRO).
sdk/appnetwork/arm-appnetwork/samples-dev/appLinkMembersListByAppLinkSample.ts Adds dev sample for appLinkMembers list.
sdk/appnetwork/arm-appnetwork/samples-dev/appLinkMembersGetSample.ts Adds dev sample for appLinkMembers get.
sdk/appnetwork/arm-appnetwork/samples-dev/appLinkMembersDeleteSample.ts Adds dev sample for appLinkMembers delete (LRO).
sdk/appnetwork/arm-appnetwork/samples-dev/appLinkMembersCreateOrUpdateSample.ts Adds dev sample for appLinkMembers createOrUpdate (LRO).
sdk/appnetwork/arm-appnetwork/sample.env Adds a top-level sample env placeholder for the package.
sdk/appnetwork/arm-appnetwork/review/arm-appnetwork-node.api.md Adds API Extractor report for main package surface.
sdk/appnetwork/arm-appnetwork/review/arm-appnetwork-models-node.api.md Adds API Extractor report for models surface.
sdk/appnetwork/arm-appnetwork/review/arm-appnetwork-api-upgradeHistories-node.api.md Adds API Extractor report for upgradeHistories API surface.
sdk/appnetwork/arm-appnetwork/review/arm-appnetwork-api-operations-node.api.md Adds API Extractor report for operations API surface.
sdk/appnetwork/arm-appnetwork/review/arm-appnetwork-api-node.api.md Adds API Extractor report for API context surface.
sdk/appnetwork/arm-appnetwork/review/arm-appnetwork-api-availableVersions-node.api.md Adds API Extractor report for availableVersions API surface.
sdk/appnetwork/arm-appnetwork/review/arm-appnetwork-api-appLinks-node.api.md Adds API Extractor report for appLinks API surface.
sdk/appnetwork/arm-appnetwork/review/arm-appnetwork-api-appLinkMembers-node.api.md Adds API Extractor report for appLinkMembers API surface.
sdk/appnetwork/arm-appnetwork/package.json Adds package manifest, exports map, scripts, deps/devDeps.
sdk/appnetwork/arm-appnetwork/metadata.json Adds generator metadata and cross-language mappings.
sdk/appnetwork/arm-appnetwork/eslint.config.mjs Adds ESLint config for the new package.
sdk/appnetwork/arm-appnetwork/api-extractor.json Adds API Extractor configuration.
sdk/appnetwork/arm-appnetwork/README.md Adds package README with authentication and logging docs.
sdk/appnetwork/arm-appnetwork/LICENSE Adds MIT license file for the package.
sdk/appnetwork/arm-appnetwork/CHANGELOG.md Adds initial changelog entry for beta.
eng/ignore-links.txt Adds link ignore entries for new package docs/NPM links.
.github/CODEOWNERS Adds CODEOWNERS entry for the new package path.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (10)

sdk/appnetwork/arm-appnetwork/warp.config.yml:1

  • These export target paths are inconsistent with the other entries (they are missing the leading ./). If warp treats these as relative to a different base (or requires normalized relative specifiers), it can break the export map generation/build. Make these paths consistent (e.g., ./src/api/...) across all entries.
    sdk/appnetwork/arm-appnetwork/src/static-helpers/urlTemplate.ts:1
  • The ifEmpty handling is inverted. For ? / & operators ifEmpty is \"=\", but the current condition prevents appending it, producing ?name instead of ?name= when the value is an empty string. Flip the condition so ifEmpty is appended when it is non-empty.
    sdk/appnetwork/arm-appnetwork/src/static-helpers/urlTemplate.ts:1
  • RFC 3986 unreserved characters are ALPHA / DIGIT / \"-\" / \".\" / \"_\" / \"~\". This implementation (and comment) omits _ and all alphanumerics, so it does not fully normalize unreserved characters as stated. Either update the regex and doc to match RFC3986 (include _ and potentially alphanumerics), or clarify that only a subset is intentionally normalized.
    sdk/appnetwork/arm-appnetwork/src/api/appLinkContext.ts:1
  • getArmEndpoint() returns endpoints with a trailing / (e.g. https://management.azure.com/). Building scopes via ${endpointUrl}/.default will produce https://management.azure.com//.default (double slash) in those cases, which can cause AAD scope mismatches. Normalize endpointUrl (trim trailing /) before building default scopes, or have getArmEndpoint() return endpoints without the trailing slash.
    sdk/appnetwork/arm-appnetwork/samples/v1-beta/typescript/tsconfig.json:1
  • Setting lib to an empty array disables the default library definitions, which will typically break compilation (e.g., missing Promise, Map, console, etc.). Replace this with appropriate libs (e.g., \"lib\": [\"ES2023\"] and add \"DOM\" if needed), or remove lib to use the defaults for the chosen target.
    sdk/appnetwork/arm-appnetwork/tsp-location.yaml:1
  • This YAML key has no value. If the generation/validation tooling expects additionalDirectories to be a list, this may parse as null and cause downstream failures. Prefer additionalDirectories: [] (empty list) or remove the key entirely if unused.
    sdk/appnetwork/arm-appnetwork/src/static-helpers/pollingHelpers.ts:1
  • This package depends on @azure/abort-controller, but uses the global AbortController here. For consistent behavior across supported runtimes (and to align with Azure SDK patterns), consider using AbortController from @azure/abort-controller instead of relying on a global implementation.
    sdk/appnetwork/arm-appnetwork/src/static-helpers/pollingHelpers.ts:1
  • addApiVersionToUrl is duplicated in both pollingHelpers.ts and pagingHelpers.ts. Consider consolidating this into a single shared helper (e.g., static-helpers/apiVersionHelpers.ts) to avoid divergence/bugs if one implementation changes.
    sdk/appnetwork/arm-appnetwork/test/public/sampleTest.spec.ts:1
  • This test is effectively a placeholder and doesn't validate any package behavior. To provide meaningful coverage, replace it with a minimal smoke test that creates the client and exercises at least one operation (ideally using @azure-tools/test-recorder with playback), or remove the file if placeholder tests are not desired.
    sdk/appnetwork/arm-appnetwork/test/public/sampleTest.spec.ts:1
  • This test is effectively a placeholder and doesn't validate any package behavior. To provide meaningful coverage, replace it with a minimal smoke test that creates the client and exercises at least one operation (ideally using @azure-tools/test-recorder with playback), or remove the file if placeholder tests are not desired.

Comment thread sdk/appnetwork/arm-appnetwork/package.json
Comment thread sdk/appnetwork/arm-appnetwork/metadata.json
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The public API surface and tooling for @azure/arm-appnetwork v1.0.0-beta.1 look good — no API design or tooling issues found.

📊 Structured Report
{"agent":"mgmt-reviewer","pr":37826,"summary":"clean","findings":[]}

Benchmarked by Management SDK PR Review

Comment thread sdk/appnetwork/arm-appnetwork/package.json
Copy link
Copy Markdown
Member

@MaryGao MaryGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deveshdama deveshdama merged commit d8b5714 into main Mar 26, 2026
78 checks passed
@deveshdama deveshdama deleted the sdkauto/@azure-arm-appnetwork-6060206 branch March 26, 2026 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management-plane library. mgmt-review-needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants