Skip to content

Fix broken pnpm-lock.yaml#37757

Closed
xirzec wants to merge 1 commit intoAzure:mainfrom
xirzec:fixPnpmlock
Closed

Fix broken pnpm-lock.yaml#37757
xirzec wants to merge 1 commit intoAzure:mainfrom
xirzec:fixPnpmlock

Conversation

@xirzec
Copy link
Copy Markdown
Member

@xirzec xirzec commented Mar 20, 2026

Suspect this was broken by #37740

Ran pnpm install locally to repair

@xirzec xirzec requested review from a team and jeremymeng as code owners March 20, 2026 21:31
Copilot AI review requested due to automatic review settings March 20, 2026 21:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Comment thread pnpm-lock.yaml
Comment on lines 40479 to 40483
optionalDependencies:
'@esbuild/aix-ppc64': 0.27.4
'@esbuild/android-arm': 0.27.4
'@esbuild/android-arm64': 0.27.4
'@esbuild/android-x64': 0.27.4
'@esbuild/darwin-arm64': 0.27.4
'@esbuild/darwin-x64': 0.27.4
'@esbuild/freebsd-arm64': 0.27.4
'@esbuild/freebsd-x64': 0.27.4
'@esbuild/linux-arm': 0.27.4
'@esbuild/linux-arm64': 0.27.4
'@esbuild/linux-ia32': 0.27.4
'@esbuild/linux-loong64': 0.27.4
'@esbuild/linux-mips64el': 0.27.4
'@esbuild/linux-ppc64': 0.27.4
'@esbuild/linux-riscv64': 0.27.4
'@esbuild/linux-s390x': 0.27.4
'@esbuild/linux-x64': 0.27.4
'@esbuild/netbsd-arm64': 0.27.4
'@esbuild/netbsd-x64': 0.27.4
'@esbuild/openbsd-arm64': 0.27.4
'@esbuild/openbsd-x64': 0.27.4
'@esbuild/openharmony-arm64': 0.27.4
'@esbuild/sunos-x64': 0.27.4
'@esbuild/win32-arm64': 0.27.4
'@esbuild/win32-ia32': 0.27.4
'@esbuild/win32-x64': 0.27.4
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

esbuild@0.27.4 now only lists a small subset of its platform-specific optional dependencies in the lockfile (e.g., missing @esbuild/darwin-arm64, @esbuild/linux-arm64, etc.). This will likely cause pnpm install --frozen-lockfile to fail or force lockfile changes when installing on other OS/CPU combinations. Regenerate the lockfile in an environment/config that does not prune optional dependencies by architecture (e.g., ensure no global supportedArchitectures/platform filters are applied) so all supported @esbuild/* entries are present.

Copilot uses AI. Check for mistakes.
Comment thread pnpm-lock.yaml
Comment thread pnpm-lock.yaml
Comment on lines 42431 to 42435
turbo@2.8.19:
optionalDependencies:
'@turbo/darwin-64': 2.8.19
'@turbo/darwin-arm64': 2.8.19
'@turbo/linux-64': 2.8.19
'@turbo/linux-arm64': 2.8.19
'@turbo/windows-64': 2.8.19
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

turbo@2.8.19 optionalDependencies are missing the arm64 variants in the lockfile (e.g., @turbo/darwin-arm64, @turbo/linux-arm64, @turbo/windows-arm64). If developers/CI run pnpm install --frozen-lockfile on those architectures, the install may fail or rewrite the lockfile. Regenerate the lockfile without architecture pruning so all Turbo platform packages are included.

Copilot uses AI. Check for mistakes.
Comment thread pnpm-lock.yaml
Comment on lines 11291 to +11293
vitest:
specifier: catalog:testing
version: 4.0.18(@opentelemetry/api@1.9.0)(@types/node@20.19.37)(@vitest/browser-playwright@4.0.18)(tsx@4.21.0)(yaml@2.8.2)
version: 4.1.0(@opentelemetry/api@1.9.0)(@types/node@20.19.37)(@vitest/browser-playwright@4.1.0)(vite@7.3.1(@types/node@20.19.37)(tsx@4.21.0)(yaml@2.8.2))
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description suggests this is only a lockfile repair, but this hunk also updates the testing toolchain versions (e.g., vitest / @vitest/* to 4.1.0). If the intent is strictly “repair without upgrading”, regenerate the lockfile in a way that preserves the previous resolved versions; otherwise please explicitly call out the Vitest upgrade in the PR description to avoid surprise behavior changes in CI/tests.

Copilot uses AI. Check for mistakes.
@xirzec
Copy link
Copy Markdown
Member Author

xirzec commented Mar 20, 2026

Closing in favor of #37758 which doesn't have the esbuild changes

@xirzec xirzec closed this Mar 20, 2026
@xirzec xirzec deleted the fixPnpmlock branch April 2, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants