[Identity] Fix MI pipeline resources creation#37736
Merged
minhanh-phan merged 14 commits intoAzure:mainfrom Mar 25, 2026
Merged
[Identity] Fix MI pipeline resources creation#37736minhanh-phan merged 14 commits intoAzure:mainfrom
minhanh-phan merged 14 commits intoAzure:mainfrom
Conversation
github-project-automation
bot
moved this to Untriaged
in Azure Identity SDK Improvements
…h-phan/azure-sdk-for-js; branch 'main' of https://github.com/Azure/azure-sdk-for-js into identity/fix-weekly-tests
scbedd
reviewed
Mar 24, 2026
minhanh-phan
requested review from
a team,
KarishmaGhiya,
benbp,
maorleger,
mikeharder and
weshaggard
as code owners
minhanh-phan
requested review from
anannya03,
Copilot,
g2vinay,
joshfree,
pvaneck and
xiangyan99
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Identity live-test pipeline matrix and job template wiring so Managed Identity (MI) test resources can be conditionally created via the intended AdditionalParameters path used by the test-resources provisioning scripts.
Changes:
- Switch Identity’s managed identity matrix from
ArmTemplateParameterstoAdditionalParametersfordeployMIResources. - Add an
AdditionalParametersvariable to the live tests job template and pass it through to the test-resources deployment template.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk/identity/identity/managed-identity-matrix.json | Routes deployMIResources through AdditionalParameters so it reaches both ARM template params and post scripts. |
| eng/pipelines/templates/jobs/live.tests.yml | Plumbs AdditionalParameters from matrix variables into deploy-test-resources.yml. |
benbp
reviewed
Mar 25, 2026
KarishmaGhiya
approved these changes
Mar 25, 2026
KarishmaGhiya
approved these changes
Mar 25, 2026
github-project-automation
bot
moved this from Untriaged
to In Progress
in Azure Identity SDK Improvements
github-project-automation
bot
moved this from In Progress
to Done
in Azure Identity SDK Improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ArmTemplateParameterstoAdditionalParametersindeploy-test-resourcesto properly enabledeployMIResourcesfrommanaged-identity-matrix.jsonto resource creation post-script. However, since Sync eng/common directory with azure-sdk-tools for PR 13968 #37311, the two variables are separate out. This causes the pipeline to failAdditionalParametersthroughtests.yml, the post-script does not have the correct variable becauseAdditionalParametersis not defined inlive.tests.yml. Thus, it is not passed through to thedeploy-test-resources.yml. This PR addresses the gap in propagating additional parameters from the pipelines viaAdditionalParameters