Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Syncs eng/common with the corresponding updates from azure-sdk-tools PR 14400, specifically extending the link verification workflow to allow controlled exceptions for relative links.
Changes:
- Added a configuration file for allowing relative links on specific paths via glob patterns.
- Updated
Verify-Links.ps1to load and apply allow-relative-link patterns per page. - Updated the pipeline template to pass the allowlist file path into the link verification script.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| eng/common/scripts/allow-relative-links.txt | Adds glob-based allowlist for pages where relative links are permitted. |
| eng/common/scripts/Verify-Links.ps1 | Implements allowlist loading + per-page override for relative-link guidance. |
| eng/common/pipelines/templates/steps/verify-links.yml | Wires the allowlist file path into the Verify-Links script invocation. |
weshaggard
approved these changes
Mar 10, 2026
…sFile parameter Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com>
…idance checks active Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com>
…-links.txt Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com>
…ll repos Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…, remove eng/** Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com>
Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com>
29c272d to
54d3077
Compare
weshaggard
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#14400 See eng/common workflow