[core][ts-http-runtime] support Blob type in getRequestBody#37424
Merged
jeremymeng merged 4 commits intoAzure:mainfrom Mar 2, 2026
Merged
[core][ts-http-runtime] support Blob type in getRequestBody#37424jeremymeng merged 4 commits intoAzure:mainfrom
jeremymeng merged 4 commits intoAzure:mainfrom
Conversation
…tringified as JSON
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the ts-http-runtime request body preparation logic to treat Blob bodies as binary payloads (instead of JSON-stringifying them), and adds browser-focused unit coverage for getRequestBody.
Changes:
- Update
getRequestBodyto returnBlobbodies as-is. - Export
getRequestBodyto enable direct unit testing. - Add a new browser test suite validating
getRequestBodybehavior for FormData/Blob/Uint8Array/ReadableStream.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sdk/core/ts-http-runtime/src/client/sendRequest.ts | Adds Blob handling in getRequestBody (and exports it for testing). |
| sdk/core/ts-http-runtime/test/browser/sendRequest.spec.ts | Adds browser unit tests for getRequestBody, including the Blob case. |
timovv
reviewed
Mar 2, 2026
timovv
approved these changes
Mar 2, 2026
Member
timovv
left a comment
timovv
left a comment
There was a problem hiding this comment.
LGTM. Do we need a changelog entry?
…e-getrequestbody-blob
Member
Author
yes! I pushed an update |
jeremymeng
changed the title
timovv
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the case of
Blobwhere we should return the body as-is.