Skip to content

Sync eng/common directory with azure-sdk-tools for PR 14196#37386

Merged
azure-sdk merged 1 commit intomainfrom
sync-eng/common-benbp/delete-storage-sync-14196
Mar 4, 2026
Merged

Sync eng/common directory with azure-sdk-tools for PR 14196#37386
azure-sdk merged 1 commit intomainfrom
sync-eng/common-benbp/delete-storage-sync-14196

Conversation

@azure-sdk
Copy link
Copy Markdown
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#14196 See eng/common workflow

Copilot AI review requested due to automatic review settings February 26, 2026 22:35
@azure-sdk azure-sdk requested a review from a team as a code owner February 26, 2026 22:35
@azure-sdk azure-sdk requested a review from benbp February 26, 2026 22:35
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Feb 26, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR syncs the eng/common directory with azure-sdk-tools PR #14196, introducing support for cleaning up Azure Storage Sync Services during test resource removal and updating the default test subscription from "Azure SDK Developer Playground" to "Azure SDK Test Resources - TME".

Changes:

  • Added new Remove-StorageSyncServices function to handle hierarchical deletion of Storage Sync Services, sync groups, and their endpoints
  • Updated default test subscription from "Azure SDK Developer Playground" to "Azure SDK Test Resources - TME" in test resource management scripts
  • Added required PowerShell module dependencies (Az.Storage 7.0.0+ and Az.StorageSync 2.1.1+) to support Storage Sync cleanup

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
eng/common/scripts/Helpers/Resource-Helpers.ps1 Added Remove-StorageSyncServices function to clean up Storage Sync Services that block resource group deletion
eng/common/TestResources/Update-TestResources.ps1 Updated default subscription to TME, added -WarningAction Ignore flags, contains subscription restoration bug
eng/common/TestResources/Remove-TestResources.ps1 Added module requirements, updated default subscription to TME, added -WarningAction Ignore flags, integrated Storage Sync cleanup

@azure-sdk azure-sdk merged commit 4a2ece1 into main Mar 4, 2026
23 checks passed
@azure-sdk azure-sdk deleted the sync-eng/common-benbp/delete-storage-sync-14196 branch March 4, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants