Skip to content

Conversation

@azure-sdk
Copy link
Collaborator

@azure-sdk azure-sdk commented Feb 11, 2026

Configurations: 'specification/codesigning/CodeSigning.Management/tspconfig.yaml', API Version: 1.0.0, SDK Release Type: stable, and CommitSHA: '095b67fa70bf85a51667949506fe090e987d2475' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5867190 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=180ccd19-ad05-f111-8406-000d3a5a7db7 Submitted by: [email protected]

Release Plan Details

@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Feb 11, 2026
@github-actions
Copy link

API Change Check

APIView identified API level changes in this PR and created the following API reviews

@azure/arm-artifactsigning

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a newly generated Azure Resource Manager (management-plane) client library package @azure/arm-artifactsigning (CodeSigning) from the specification/codesigning/CodeSigning.Management TypeSpec configuration, along with CI wiring and supporting metadata for release/review.

Changes:

  • Added the new sdk/artifactsigning/arm-artifactsigning package (client, models, helpers, tests, samples, API reports, and package metadata).
  • Added CI pipeline definition for the service directory and updated repo metadata (CODEOWNERS, link ignore list, pnpm lockfile).
  • Added TypeScript/Vitest/tsconfig wiring to build and test the new package across Node/Browser/ESM variants.

Reviewed changes

Copilot reviewed 102 out of 103 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
sdk/artifactsigning/ci.mgmt.yml Adds CI pipeline definition for the new management package.
sdk/artifactsigning/arm-artifactsigning/vitest.esm.config.ts Adds Vitest ESM config for the package.
sdk/artifactsigning/arm-artifactsigning/vitest.config.ts Adds base Vitest config forwarding to repo shared config.
sdk/artifactsigning/arm-artifactsigning/vitest.browser.config.ts Adds Vitest browser config forwarding to repo shared config.
sdk/artifactsigning/arm-artifactsigning/tsp-location.yaml Records the TypeSpec spec repo location/commit for the generated SDK.
sdk/artifactsigning/arm-artifactsigning/tsconfig.test.node.json Adds Node test tsconfig references/paths.
sdk/artifactsigning/arm-artifactsigning/tsconfig.test.json Adds composite test project references.
sdk/artifactsigning/arm-artifactsigning/tsconfig.src.json Adds source compilation tsconfig extending repo base.
sdk/artifactsigning/arm-artifactsigning/tsconfig.snippets.json Adds snippets tsconfig extending repo base.
sdk/artifactsigning/arm-artifactsigning/tsconfig.samples.json Adds samples tsconfig and path mapping to built output.
sdk/artifactsigning/arm-artifactsigning/tsconfig.json Adds solution-style TS project references.
sdk/artifactsigning/arm-artifactsigning/tsconfig.browser.config.json Adds browser build/test path mappings.
sdk/artifactsigning/arm-artifactsigning/test/snippets.spec.ts Adds snippet compilation test source for README snippets.
sdk/artifactsigning/arm-artifactsigning/test/public/utils/recordedClient.ts Adds test-recorder helper wiring for playback/record.
sdk/artifactsigning/arm-artifactsigning/test/public/sampleTest.spec.ts Adds placeholder public test file.
sdk/artifactsigning/arm-artifactsigning/src/static-helpers/urlTemplate.ts Adds RFC6570 URL template expansion helper used by generated operations.
sdk/artifactsigning/arm-artifactsigning/src/static-helpers/pollingHelpers.ts Adds LRO polling helper integration with @azure/core-lro.
sdk/artifactsigning/arm-artifactsigning/src/static-helpers/pagingHelpers.ts Adds paging helpers to build PagedAsyncIterableIterator for list APIs.
sdk/artifactsigning/arm-artifactsigning/src/static-helpers/cloudSettingHelpers.ts Adds cloud setting to ARM endpoint resolution helper.
sdk/artifactsigning/arm-artifactsigning/src/restorePollerHelpers.ts Adds restore-from-serialized-state helper for LRO pollers.
sdk/artifactsigning/arm-artifactsigning/src/models/models.ts Adds generated model types and serializers/deserializers.
sdk/artifactsigning/arm-artifactsigning/src/models/index.ts Adds public re-exports for generated model types.
sdk/artifactsigning/arm-artifactsigning/src/logger.ts Adds client logger wiring.
sdk/artifactsigning/arm-artifactsigning/src/index.ts Adds package entrypoint exports (client, models, options, helpers).
sdk/artifactsigning/arm-artifactsigning/src/codeSigningClient.ts Adds the main CodeSigningClient wrapper and operation-group wiring.
sdk/artifactsigning/arm-artifactsigning/src/classic/operations/index.ts Adds classic operation group wrapper for provider operations.
sdk/artifactsigning/arm-artifactsigning/src/classic/index.ts Adds classic operation group exports.
sdk/artifactsigning/arm-artifactsigning/src/classic/codeSigningAccounts/index.ts Adds classic operation group wrapper for CodeSigningAccounts.
sdk/artifactsigning/arm-artifactsigning/src/classic/certificateProfiles/index.ts Adds classic operation group wrapper for CertificateProfiles.
sdk/artifactsigning/arm-artifactsigning/src/api/operations/options.ts Adds options type for Operations list API.
sdk/artifactsigning/arm-artifactsigning/src/api/operations/operations.ts Adds generated REST-layer implementation for Operations list API.
sdk/artifactsigning/arm-artifactsigning/src/api/operations/index.ts Adds REST-layer exports for Operations API.
sdk/artifactsigning/arm-artifactsigning/src/api/index.ts Adds REST-layer top-level exports.
sdk/artifactsigning/arm-artifactsigning/src/api/codeSigningContext.ts Adds REST client context factory and client options shape.
sdk/artifactsigning/arm-artifactsigning/src/api/codeSigningAccounts/options.ts Adds REST-layer options types for CodeSigningAccounts APIs.
sdk/artifactsigning/arm-artifactsigning/src/api/codeSigningAccounts/operations.ts Adds generated REST-layer implementation for CodeSigningAccounts APIs.
sdk/artifactsigning/arm-artifactsigning/src/api/codeSigningAccounts/index.ts Adds REST-layer exports for CodeSigningAccounts API.
sdk/artifactsigning/arm-artifactsigning/src/api/certificateProfiles/options.ts Adds REST-layer options types for CertificateProfiles APIs.
sdk/artifactsigning/arm-artifactsigning/src/api/certificateProfiles/operations.ts Adds generated REST-layer implementation for CertificateProfiles APIs.
sdk/artifactsigning/arm-artifactsigning/src/api/certificateProfiles/index.ts Adds REST-layer exports for CertificateProfiles API.
sdk/artifactsigning/arm-artifactsigning/samples/v1-beta/typescript/tsconfig.json Adds TS compilation settings for published TypeScript samples.
sdk/artifactsigning/arm-artifactsigning/samples/v1-beta/typescript/src/operationsListSample.ts Adds TypeScript sample for listing provider operations.
sdk/artifactsigning/arm-artifactsigning/samples/v1-beta/typescript/src/codeSigningAccountsUpdateSample.ts Adds TypeScript sample for updating accounts.
sdk/artifactsigning/arm-artifactsigning/samples/v1-beta/typescript/src/codeSigningAccountsListBySubscriptionSample.ts Adds TypeScript sample for listing by subscription.
sdk/artifactsigning/arm-artifactsigning/samples/v1-beta/typescript/src/codeSigningAccountsListByResourceGroupSample.ts Adds TypeScript sample for listing by resource group.
sdk/artifactsigning/arm-artifactsigning/samples/v1-beta/typescript/src/codeSigningAccountsGetSample.ts Adds TypeScript sample for get account.
sdk/artifactsigning/arm-artifactsigning/samples/v1-beta/typescript/src/codeSigningAccountsDeleteSample.ts Adds TypeScript sample for delete account.
sdk/artifactsigning/arm-artifactsigning/samples/v1-beta/typescript/src/codeSigningAccountsCreateSample.ts Adds TypeScript sample for create account.
sdk/artifactsigning/arm-artifactsigning/samples/v1-beta/typescript/src/codeSigningAccountsCheckNameAvailabilitySample.ts Adds TypeScript sample for name availability.
sdk/artifactsigning/arm-artifactsigning/samples/v1-beta/typescript/src/certificateProfilesRevokeCertificateSample.ts Adds TypeScript sample for revoking a certificate.
sdk/artifactsigning/arm-artifactsigning/samples/v1-beta/typescript/src/certificateProfilesListByCodeSigningAccountSample.ts Adds TypeScript sample for listing certificate profiles.
sdk/artifactsigning/arm-artifactsigning/samples/v1-beta/typescript/src/certificateProfilesGetSample.ts Adds TypeScript sample for getting a certificate profile.
sdk/artifactsigning/arm-artifactsigning/samples/v1-beta/typescript/src/certificateProfilesDeleteSample.ts Adds TypeScript sample for deleting a certificate profile.
sdk/artifactsigning/arm-artifactsigning/samples/v1-beta/typescript/src/certificateProfilesCreateSample.ts Adds TypeScript sample for creating a certificate profile.
sdk/artifactsigning/arm-artifactsigning/samples/v1-beta/typescript/sample.env Adds sample env placeholder for TS samples.
sdk/artifactsigning/arm-artifactsigning/samples/v1-beta/typescript/package.json Adds TS samples package manifest.
sdk/artifactsigning/arm-artifactsigning/samples/v1-beta/typescript/README.md Adds TS samples README and index.
sdk/artifactsigning/arm-artifactsigning/samples/v1-beta/javascript/sample.env Adds sample env placeholder for JS samples.
sdk/artifactsigning/arm-artifactsigning/samples/v1-beta/javascript/package.json Adds JS samples package manifest.
sdk/artifactsigning/arm-artifactsigning/samples/v1-beta/javascript/operationsListSample.js Adds JS sample for listing provider operations.
sdk/artifactsigning/arm-artifactsigning/samples/v1-beta/javascript/codeSigningAccountsUpdateSample.js Adds JS sample for updating accounts.
sdk/artifactsigning/arm-artifactsigning/samples/v1-beta/javascript/codeSigningAccountsListBySubscriptionSample.js Adds JS sample for listing by subscription.
sdk/artifactsigning/arm-artifactsigning/samples/v1-beta/javascript/codeSigningAccountsListByResourceGroupSample.js Adds JS sample for listing by resource group.
sdk/artifactsigning/arm-artifactsigning/samples/v1-beta/javascript/codeSigningAccountsGetSample.js Adds JS sample for get account.
sdk/artifactsigning/arm-artifactsigning/samples/v1-beta/javascript/codeSigningAccountsDeleteSample.js Adds JS sample for delete account.
sdk/artifactsigning/arm-artifactsigning/samples/v1-beta/javascript/codeSigningAccountsCreateSample.js Adds JS sample for create account.
sdk/artifactsigning/arm-artifactsigning/samples/v1-beta/javascript/codeSigningAccountsCheckNameAvailabilitySample.js Adds JS sample for name availability.
sdk/artifactsigning/arm-artifactsigning/samples/v1-beta/javascript/certificateProfilesRevokeCertificateSample.js Adds JS sample for revoking a certificate.
sdk/artifactsigning/arm-artifactsigning/samples/v1-beta/javascript/certificateProfilesListByCodeSigningAccountSample.js Adds JS sample for listing certificate profiles.
sdk/artifactsigning/arm-artifactsigning/samples/v1-beta/javascript/certificateProfilesGetSample.js Adds JS sample for getting a certificate profile.
sdk/artifactsigning/arm-artifactsigning/samples/v1-beta/javascript/certificateProfilesDeleteSample.js Adds JS sample for deleting a certificate profile.
sdk/artifactsigning/arm-artifactsigning/samples/v1-beta/javascript/certificateProfilesCreateSample.js Adds JS sample for creating a certificate profile.
sdk/artifactsigning/arm-artifactsigning/samples/v1-beta/javascript/README.md Adds JS samples README and index.
sdk/artifactsigning/arm-artifactsigning/samples-dev/operationsListSample.ts Adds dev sample for listing provider operations.
sdk/artifactsigning/arm-artifactsigning/samples-dev/codeSigningAccountsUpdateSample.ts Adds dev sample for updating accounts.
sdk/artifactsigning/arm-artifactsigning/samples-dev/codeSigningAccountsListBySubscriptionSample.ts Adds dev sample for listing by subscription.
sdk/artifactsigning/arm-artifactsigning/samples-dev/codeSigningAccountsListByResourceGroupSample.ts Adds dev sample for listing by resource group.
sdk/artifactsigning/arm-artifactsigning/samples-dev/codeSigningAccountsGetSample.ts Adds dev sample for get account.
sdk/artifactsigning/arm-artifactsigning/samples-dev/codeSigningAccountsDeleteSample.ts Adds dev sample for delete account.
sdk/artifactsigning/arm-artifactsigning/samples-dev/codeSigningAccountsCreateSample.ts Adds dev sample for create account.
sdk/artifactsigning/arm-artifactsigning/samples-dev/codeSigningAccountsCheckNameAvailabilitySample.ts Adds dev sample for name availability.
sdk/artifactsigning/arm-artifactsigning/samples-dev/certificateProfilesRevokeCertificateSample.ts Adds dev sample for revoking a certificate.
sdk/artifactsigning/arm-artifactsigning/samples-dev/certificateProfilesListByCodeSigningAccountSample.ts Adds dev sample for listing certificate profiles.
sdk/artifactsigning/arm-artifactsigning/samples-dev/certificateProfilesGetSample.ts Adds dev sample for getting a certificate profile.
sdk/artifactsigning/arm-artifactsigning/samples-dev/certificateProfilesDeleteSample.ts Adds dev sample for deleting a certificate profile.
sdk/artifactsigning/arm-artifactsigning/samples-dev/certificateProfilesCreateSample.ts Adds dev sample for creating a certificate profile.
sdk/artifactsigning/arm-artifactsigning/sample.env Adds root sample env placeholder.
sdk/artifactsigning/arm-artifactsigning/review/arm-artifactsigning-node.api.md Adds API Extractor report for the package.
sdk/artifactsigning/arm-artifactsigning/review/arm-artifactsigning-models-node.api.md Adds API Extractor report for models surface area.
sdk/artifactsigning/arm-artifactsigning/review/arm-artifactsigning-api-operations-node.api.md Adds API Extractor report for operations subpath.
sdk/artifactsigning/arm-artifactsigning/review/arm-artifactsigning-api-node.api.md Adds API Extractor report for api subpath.
sdk/artifactsigning/arm-artifactsigning/review/arm-artifactsigning-api-codeSigningAccounts-node.api.md Adds API Extractor report for codeSigningAccounts api subpath.
sdk/artifactsigning/arm-artifactsigning/review/arm-artifactsigning-api-certificateProfiles-node.api.md Adds API Extractor report for certificateProfiles api subpath.
sdk/artifactsigning/arm-artifactsigning/package.json Adds the package manifest, exports map, scripts, deps, and versioning.
sdk/artifactsigning/arm-artifactsigning/metadata.json Adds generation metadata (apiVersion, emitter, cross-language ids).
sdk/artifactsigning/arm-artifactsigning/eslint.config.mjs Adds eslint config wiring for the new package.
sdk/artifactsigning/arm-artifactsigning/api-extractor.json Adds API Extractor configuration inheritance.
sdk/artifactsigning/arm-artifactsigning/README.md Adds package README with usage and snippets.
sdk/artifactsigning/arm-artifactsigning/LICENSE Adds package license file.
sdk/artifactsigning/arm-artifactsigning/CHANGELOG.md Adds initial changelog entry for first release.
pnpm-lock.yaml Adds workspace dependency lock entries for the new package.
eng/ignore-links.txt Adds ignored links for docs validation (package/docs URLs).
.github/CODEOWNERS Adds code owners for the new service directory/package.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Comment on lines +15 to +18
const subscriptionId = "00000000-1111-2222-3333-444444444444";
const client = new CodeSigningClient(credential, subscriptionId);
await client.codeSigningAccounts.delete("MyResourceGroup", "MyAccount");
}
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

client.codeSigningAccounts.delete(...) returns a PollerLike, but this sample just awaits the poller object and never polls for completion. Update the sample to call pollUntilDone() so it actually waits for the delete LRO to finish (and surfaces failures).

Copilot uses AI. Check for mistakes.
Comment on lines +17 to +31
const result = await client.certificateProfiles.create(
"MyResourceGroup",
"MyAccount",
"profileA",
{
properties: {
profileType: "PublicTrust",
identityValidationId: "00000000-1234-5678-3333-444444444444",
includePostalCode: true,
includeStreetAddress: false,
},
},
);
console.log(result);
}
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sample treats client.certificateProfiles.create(...) as if it returns the created profile, but the method returns a PollerLike. result will be a poller and the operation may still be running. Call pollUntilDone() on the poller and log the final CertificateProfile instead.

Copilot uses AI. Check for mistakes.
Comment on lines +15 to +18
const subscriptionId = "00000000-1111-2222-3333-444444444444";
const client = new CodeSigningClient(credential, subscriptionId);
await client.certificateProfiles.delete("MyResourceGroup", "MyAccount", "profileA");
}
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

client.certificateProfiles.delete(...) returns a PollerLike, but this sample just awaits the poller object and never polls for completion. Update the sample to call pollUntilDone() so it waits for the delete LRO to finish.

Copilot uses AI. Check for mistakes.
Comment on lines +2 to +4
"name": "@azure/arm-artifactsigning",
"version": "1.0.0-beta.1",
"description": "A generated SDK for CodeSigningClient.",
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description says the SDK release type is stable, but the package version is set to a prerelease (1.0.0-beta.1). If this is intended to be a stable release, the version (and corresponding userAgentInfo/changelog entries) should not include the -beta.* suffix.

Copilot uses AI. Check for mistakes.
Comment on lines +36 to +48
const endpointUrl =
options.endpoint ?? getArmEndpoint(options.cloudSetting) ?? "https://management.azure.com";
const prefixFromOptions = options?.userAgentOptions?.userAgentPrefix;
const userAgentInfo = `azsdk-js-arm-artifactsigning/1.0.0-beta.1`;
const userAgentPrefix = prefixFromOptions
? `${prefixFromOptions} azsdk-js-api ${userAgentInfo}`
: `azsdk-js-api ${userAgentInfo}`;
const { apiVersion: _, ...updatedOptions } = {
...options,
userAgentOptions: { userAgentPrefix },
loggingOptions: { logger: options.loggingOptions?.logger ?? logger.info },
credentials: { scopes: options.credentials?.scopes ?? [`${endpointUrl}/.default`] },
};
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

createCodeSigning builds the default AAD scope using ${endpointUrl}/.default, but getArmEndpoint() returns URLs with a trailing slash (e.g. https://management.azure.com/). This can yield a scope like https://management.azure.com//.default (double slash), which is not a valid resource/scope. Trim trailing slashes from endpointUrl (or use new URL(endpointUrl).origin) before forming the default scope.

Copilot uses AI. Check for mistakes.
Comment on lines +28 to +35
const prefixFromOptions = options?.userAgentOptions?.userAgentPrefix;
const userAgentPrefix = prefixFromOptions
? `${prefixFromOptions} azsdk-js-client`
: `azsdk-js-client`;
this._client = createCodeSigning(credential, subscriptionId, {
...options,
userAgentOptions: { userAgentPrefix },
});
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeSigningClient recomputes userAgentPrefix and then passes userAgentOptions to createCodeSigning, which overwrites the azsdk-js-api ${userAgentInfo} value that createCodeSigning already sets. This likely drops the package name/version from the final User-Agent header. Consider removing the User-Agent rewriting here (or merging prefixes without replacing the value set by createCodeSigning).

Copilot uses AI. Check for mistakes.
Comment on lines +17 to +20
const result = await client.codeSigningAccounts.create("MyResourceGroup", "MyAccount", {
location: "westus",
properties: { sku: { name: "Basic" } },
});
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sample treats client.codeSigningAccounts.create(...) as if it returns the created resource, but the method returns a PollerLike. As written, result will be a poller and the long-running operation won't be awaited to completion. Update the sample to call pollUntilDone() on the returned poller and log the final result instead.

Copilot uses AI. Check for mistakes.
Comment on lines +17 to +20
const result = await client.codeSigningAccounts.update("MyResourceGroup", "MyAccount", {
tags: { key1: "value1" },
});
console.log(result);
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sample treats client.codeSigningAccounts.update(...) as if it returns the updated resource, but the method returns a PollerLike. result will be a poller and the update may still be in progress when the sample exits. Call pollUntilDone() on the poller to await completion and get the final resource.

Copilot uses AI. Check for mistakes.
@kazrael2119 kazrael2119 added the Self-Service Release PR for self-service release label Feb 12, 2026

- [Source code](https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/artifactsigning/arm-artifactsigning)
- [Package (NPM)](https://www.npmjs.com/package/@azure/arm-artifactsigning)
- [API reference documentation](https://learn.microsoft.com/javascript/api/@azure/arm-artifactsigning)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [API reference documentation](https://learn.microsoft.com/javascript/api/@azure/arm-artifactsigning)
- [API reference documentation](https://learn.microsoft.com/javascript/api/@azure/arm-artifactsigning?view=azure-node-preview)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management-plane library. Self-Service Release PR for self-service release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants