[AutoPR @azure-arm-managedops]-generated-from-SDK Generation - JS-5788708#37142
Conversation
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
There was a problem hiding this comment.
Pull request overview
This is an auto-generated SDK for the Azure Managed Operations API (version 2025-07-28-preview). The PR introduces a new management client library @azure/arm-managedops that provides TypeScript/JavaScript bindings for managing ManagedOps resources in Azure, including operations for creating, updating, deleting, and listing ManagedOps instances.
Changes:
- Added new
@azure/arm-managedopspackage with full client implementation, models, and API operations - Includes generated code for REST API bindings, long-running operations, paging, and URL templating
- Provides sample code in both TypeScript and JavaScript for common operations
- Adds CI/CD pipeline configuration, test infrastructure, and documentation
Reviewed changes
Copilot reviewed 76 out of 77 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/managedops/ci.mgmt.yml | CI/CD pipeline configuration for the managedops package |
| sdk/managedops/arm-managedops/package.json | Package manifest with dependencies and build scripts |
| sdk/managedops/arm-managedops/src/managedOpsClient.ts | Main client class for the ManagedOps API |
| sdk/managedops/arm-managedops/src/models/models.ts | TypeScript model definitions and serializers/deserializers |
| sdk/managedops/arm-managedops/src/api/managedOps/operations.ts | Implementation of CRUD operations for ManagedOps resources |
| sdk/managedops/arm-managedops/src/static-helpers/*.ts | Helper utilities for polling, paging, URL templating, and cloud settings |
| sdk/managedops/arm-managedops/samples-dev/*.ts | Development sample code demonstrating API usage |
| sdk/managedops/arm-managedops/samples/v1-beta/**/* | Published sample code for TypeScript and JavaScript |
| sdk/managedops/arm-managedops/test/**/*.ts | Test infrastructure and sample test files |
| sdk/managedops/arm-managedops/README.md | Package documentation with getting started guide |
| sdk/managedops/arm-managedops/CHANGELOG.md | Release notes for the initial beta release |
| .github/CODEOWNERS | Added code ownership for the new package |
| eng/ignore-links.txt | Added documentation links to ignore list |
| pnpm-lock.yaml | Updated lock file with new package dependencies |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
| const client = new ManagedOpsClient(credential, subscriptionId); | ||
| const result = await client.managedOps.createOrUpdate("default", { | ||
| properties: { | ||
| sku: { name: "ManagedOps", tier: "Essential" }, |
There was a problem hiding this comment.
The sample code is attempting to set a read-only property 'sku' on the ManagedOp resource. According to the model definition, the 'sku' property is marked as 'readonly' in ManagedOpsProperties. This will cause a runtime error or unexpected behavior when users try to use this sample. The 'sku' property should be removed from this sample, or if it's meant to be writable, the model definition needs to be corrected.
| sku: { name: "ManagedOps", tier: "Essential" }, |
There was a problem hiding this comment.
@kazrael2119 Could you help confirm if this is a valid issue?
There was a problem hiding this comment.
seems this is a codegen bug, I will create an issue and track this
There was a problem hiding this comment.
|
|
||
| // afterEach(async function() { | ||
| // await recorder.stop(); | ||
| // ); |
There was a problem hiding this comment.
There's a syntax error on line 23. The closing parenthesis for the afterEach function is missing, but a semicolon is present instead. This should be '); to properly close the function call.
There was a problem hiding this comment.
@v-jiaodi Could you create an issue in codegen repo to fix this?
| const client = new ManagedOpsClient(credential, subscriptionId); | ||
| const result = await client.managedOps.createOrUpdate("default", { | ||
| properties: { | ||
| sku: { name: "ManagedOps", tier: "Essential" }, |
There was a problem hiding this comment.
The sample code is attempting to set a read-only property 'sku' on the ManagedOp resource. According to the model definition in src/models/models.ts, the 'sku' property is marked as 'readonly' in ManagedOpsProperties (line 208). This will cause a TypeScript compilation error when users try to use this sample. The 'sku' property should be removed from this sample, or if it's meant to be writable, the model definition needs to be corrected.
| sku: { name: "ManagedOps", tier: "Essential" }, |
sdk/managedops/arm-managedops/samples/v1-beta/typescript/src/managedOpsCreateOrUpdateSample.ts
Outdated
Show resolved
Hide resolved
273a6f1 to
39b6a09
Compare
Thanks for the guide! I've resolved the CI issues.
Thanks for the link! We've added live tests to our Dotnet SDK release but currently are not planning to add them to this PR for the preview release. We are considering including them for the stable release (our product is still in private preview) |
…t/tspconfig.yaml', API Version: 2025-07-28-preview, SDK Release Type: beta, and CommitSHA: '83408dfe4894a9b5a5d3989023647bce792efc5f' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5788708 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
d6d14bd to
cf60047
Compare
|
LGTM |
|
/azp run prepare-pipelines |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Configurations: 'specification/managedoperations/ManagedOps.Management/tspconfig.yaml', API Version: 2025-07-28-preview, SDK Release Type: beta, and CommitSHA: '83408dfe4894a9b5a5d3989023647bce792efc5f' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5788708 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=6712851c-60ef-f011-8407-000d3a5b0bfe Submitted by: wcashman@microsoft.com
Release Plan Details
Spec pull request: move api specs from private to public repo for managedops azure-rest-api-specs#39501
Spec API version: 2025-07-28-preview