[App Configuration] - Head request support#36959
Merged
linglingye001 merged 9 commits intomainfrom Jan 26, 2026
Merged
Conversation
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds HEAD request support to the App Configuration client through a new checkConfigurationSettings method. This allows clients to efficiently check if configuration settings have changed by retrieving only HTTP headers (including ETags) without the response body.
Changes:
- Added
checkConfigurationSettingsmethod that performs HEAD requests to check configuration settings status - Implemented proper handling of 200 (success) and 304 (not modified) responses with ETag support
- Added comprehensive test coverage for the new method including ETag-based change detection
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| sdk/appconfiguration/app-configuration/src/appConfigurationClient.ts | Implements the new checkConfigurationSettings public method and private helper checkConfigurationSettingsRequest, adds imports for generated types |
| sdk/appconfiguration/app-configuration/test/public/index.spec.ts | Adds test suite covering basic HEAD requests, 304 responses with unchanged ETags, and 200 responses when content changes |
| sdk/appconfiguration/app-configuration/review/app-configuration-node.api.md | Updates API review file to include the new public method signature |
| sdk/appconfiguration/app-configuration/assets.json | Updates test assets tag to new recording version |
Comments suppressed due to low confidence (1)
sdk/appconfiguration/app-configuration/src/appConfigurationClient.ts:55
- The KeyValueListResult import appears to be unused. This import was added but is not referenced anywhere in the code. Consider removing it to keep imports clean.
} from "./generated/src/models/index.js";
sdk/appconfiguration/app-configuration/src/appConfigurationClient.ts
Outdated
Show resolved
Hide resolved
sdk/appconfiguration/app-configuration/test/public/index.spec.ts
Outdated
Show resolved
Hide resolved
sdk/appconfiguration/app-configuration/src/appConfigurationClient.ts
Outdated
Show resolved
Hide resolved
sdk/appconfiguration/app-configuration/src/appConfigurationClient.ts
Outdated
Show resolved
Hide resolved
sdk/appconfiguration/app-configuration/test/public/index.spec.ts
Outdated
Show resolved
Hide resolved
sdk/appconfiguration/app-configuration/test/public/index.spec.ts
Outdated
Show resolved
Hide resolved
zhiyuanliang-ms
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists